mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: James Simmons <jsimmons@infradead.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	devel@driverdev.osuosl.org,
	Andreas Dilger <andreas.dilger@intel.com>,
	Oleg Drokin <oleg.drokin@intel.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Lustre Development List <lustre-devel@lists.lustre.org>,
	"John L. Hammond" <john.hammond@intel.com>,
	James Simmons <jsimmons@infradead.org>
Subject: [PATCH 08/20] staging: lustre: ptlrpc: correct use of list_add_tail()
Date: Wed, 26 Jul 2017 11:22:24 -0400	[thread overview]
Message-ID: <1501082556-17962-9-git-send-email-jsimmons@infradead.org> (raw)
In-Reply-To: <1501082556-17962-1-git-send-email-jsimmons@infradead.org>

From: "John L. Hammond" <john.hammond@intel.com>

With people starting to test security enabled ptlrpc
a list_del corruption was reported. The reason for
this error was tracked down to wrong arguments to
list_add_tail(). In sptlrpc_gc_add_sec() swap the
arguments to list_add_tail() so that it does what
we meant it to do.

Signed-off-by: John L. Hammond <john.hammond@intel.com>
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8270
Reviewed-on: http://review.whamcloud.com/20784
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Reviewed-by: Bob Glossman <bob.glossman@intel.com>
Reviewed-by: Dmitry Eremin <dmitry.eremin@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: James Simmons <jsimmons@infradead.org>
---
 drivers/staging/lustre/lustre/ptlrpc/sec_gc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/lustre/lustre/ptlrpc/sec_gc.c b/drivers/staging/lustre/lustre/ptlrpc/sec_gc.c
index 8ffd000..026bec7 100644
--- a/drivers/staging/lustre/lustre/ptlrpc/sec_gc.c
+++ b/drivers/staging/lustre/lustre/ptlrpc/sec_gc.c
@@ -66,7 +66,7 @@ void sptlrpc_gc_add_sec(struct ptlrpc_sec *sec)
 	sec->ps_gc_next = ktime_get_real_seconds() + sec->ps_gc_interval;
 
 	spin_lock(&sec_gc_list_lock);
-	list_add_tail(&sec_gc_list, &sec->ps_gc_list);
+	list_add_tail(&sec->ps_gc_list, &sec_gc_list);
 	spin_unlock(&sec_gc_list_lock);
 
 	CDEBUG(D_SEC, "added sec %p(%s)\n", sec, sec->ps_policy->sp_name);
-- 
1.8.3.1

  parent reply	other threads:[~2017-07-26 15:22 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-26 15:22 [PATCH 00/20] staging: lustre: batch of fixes to decrease test failures James Simmons
2017-07-26 15:22 ` [PATCH 01/20] staging: lustre: osc: soft lock - osc_makes_rpc() James Simmons
2017-07-26 15:22 ` [PATCH 02/20] staging: lustre: ldlm: restore missing newlines in ldlm sysfs files James Simmons
2017-07-26 15:22 ` [PATCH 03/20] staging: lustre: ldlm: crash on umount in cleanup_resource James Simmons
2017-07-26 15:22 ` [PATCH 04/20] staging: lustre: lov: fix 'control flow' error in lov_io_init_released James Simmons
2017-07-26 15:22 ` [PATCH 05/20] staging: lustre: lov: remove unused code James Simmons
2017-07-26 15:22 ` [PATCH 06/20] staging: lustre: lmv: assume a real connection in lmv_connect() James Simmons
2017-07-26 15:22 ` [PATCH 07/20] staging: lustre: lov: Ensure correct operation for large object sizes James Simmons
2017-07-26 15:22 ` James Simmons [this message]
2017-07-26 15:22 ` [PATCH 09/20] staging: lustre: ptlrpc: no need to reassign mbits for replay James Simmons
2017-07-26 15:22 ` [PATCH 10/20] staging: lustre: ldlm: restore interval_iterate_reverse function James Simmons
2017-07-26 15:22 ` [PATCH 11/20] staging: lustre: lustre: fix all less than 0 comparison for unsigned values James Simmons
2017-07-26 15:22 ` [PATCH 12/20] staging: lustre: linkea: linkEA size limitation James Simmons
2017-07-26 15:22 ` [PATCH 13/20] staging: lustre: ptlrpc: restore 64-bit time for struct ptlrpc_cli_req James Simmons
2017-07-26 15:22 ` [PATCH 14/20] staging: lustre: ptlrpc: don't use CFS_DURATION_T for time64_t James Simmons
2017-07-26 15:22 ` [PATCH 15/20] staging: lustre: ptlrpc: print times in microseconds James Simmons
2017-07-26 15:22 ` [PATCH 16/20] staging: lustre: libcfs: fix test for libcfs_ioctl_hdr minimum size James Simmons
2017-07-26 15:22 ` [PATCH 17/20] staging: lustre: llite: allow cached acls James Simmons
2017-07-26 15:22 ` [PATCH 18/20] staging: lustre: llite: Remove filtering of seclabel xattr James Simmons
2017-07-27 19:35   ` James Simmons
2017-07-30 15:04     ` Greg Kroah-Hartman
2017-07-26 15:22 ` [PATCH 19/20] staging: lustre: llite: add xattr.h header to xattr.c James Simmons
2017-07-26 15:22 ` [PATCH 20/20] staging: lustre: llite: set security xattr using __vfs_setxattr James Simmons

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1501082556-17962-9-git-send-email-jsimmons@infradead.org \
    --to=jsimmons@infradead.org \
    --cc=andreas.dilger@intel.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=john.hammond@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lustre-devel@lists.lustre.org \
    --cc=oleg.drokin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®