From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751668AbdG1HlT (ORCPT ); Fri, 28 Jul 2017 03:41:19 -0400 Received: from lelnx193.ext.ti.com ([198.47.27.77]:14392 "EHLO lelnx193.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751045AbdG1HlS (ORCPT ); Fri, 28 Jul 2017 03:41:18 -0400 From: Keerthy To: , CC: , , , Subject: [PATCH] soc: ti: knav: Add a NULL pointer check for kdev in knav_pool_create Date: Fri, 28 Jul 2017 13:09:16 +0530 Message-ID: <1501227556-21087-1-git-send-email-j-keerthy@ti.com> X-Mailer: git-send-email 1.9.1 MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org knav_pool_create is an exported function. In the event of a call before knav_queue_probe, we encounter a NULL pointer dereference in the following line. Hence return -EPROBE_DEFER to the caller till the kdev pointer is non-NULL. Signed-off-by: Keerthy --- drivers/soc/ti/knav_qmss_queue.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/soc/ti/knav_qmss_queue.c b/drivers/soc/ti/knav_qmss_queue.c index 279e7c5..d91626b 100644 --- a/drivers/soc/ti/knav_qmss_queue.c +++ b/drivers/soc/ti/knav_qmss_queue.c @@ -745,6 +745,9 @@ void *knav_pool_create(const char *name, bool slot_found; int ret; + if (!kdev) + return -EPROBE_DEFER; + if (!kdev->dev) return ERR_PTR(-ENODEV); -- 1.9.1