mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Peter Zijlstra <peterz@infradead.org>
Subject: [PATCH 0/3] jump_labels: concurrency fixes
Date: Tue,  1 Aug 2017 17:24:03 +0200	[thread overview]
Message-ID: <1501601046-35683-1-git-send-email-pbonzini@redhat.com> (raw)

Any use of key->enabled (that is static_key_enabled and static_key_count)
outside jump_label_lock should handle its own serialization.  Notably
among those that don't do so is static_key_enable/disable itself.  Once
those are fixed (patch 1), they can be used to fix the actual offenders in
net/ (patch 2).

Patch 3 is not fixing anything, but the function cannot be used correctly
from any place other than cpuset.c itself so it is moved there.

Based on discussion with Peter Zijlstra.

Paolo

Paolo Bonzini (3):
  jump_labels: fix concurrent static_key_enable/disable()
  jump_labels: do not use unserialized static_key_enabled
  cpuset: make nr_cpusets private

 Documentation/static-keys.txt |  5 ++++
 include/linux/cpuset.h        |  6 -----
 include/linux/jump_label.h    | 22 ++++++++--------
 kernel/cgroup/cpuset.c        |  7 +++++
 kernel/jump_label.c           | 59 +++++++++++++++++++++++++++----------------
 net/ipv4/udp.c                |  3 +--
 net/ipv6/udp.c                |  3 +--
 7 files changed, 63 insertions(+), 42 deletions(-)

-- 
1.8.3.1

             reply	other threads:[~2017-08-01 15:24 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-01 15:24 Paolo Bonzini [this message]
2017-08-01 15:24 ` [PATCH 1/3] jump_labels: fix concurrent static_key_enable/disable() Paolo Bonzini
2017-08-01 16:45   ` Peter Zijlstra
2017-08-01 16:46     ` Paolo Bonzini
2017-08-10 12:12   ` [tip:locking/core] jump_label: Fix " tip-bot for Paolo Bonzini
2017-08-01 15:24 ` [PATCH 2/3] jump_labels: do not use unserialized static_key_enabled Paolo Bonzini
2017-08-01 20:52   ` Eric Dumazet
2017-08-02  5:45     ` Paolo Bonzini
2017-08-10 12:12   ` [tip:locking/core] jump_label: Do not use unserialized static_key_enabled() tip-bot for Paolo Bonzini
2017-08-01 15:24 ` [PATCH 3/3] cpuset: make nr_cpusets private Paolo Bonzini
2017-08-02  1:08   ` Zefan Li
2017-08-10 12:13   ` [tip:locking/core] cpuset: Make " tip-bot for Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1501601046-35683-1-git-send-email-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®