From: David Lechner <david@lechnology.com>
To: dri-devel@lists.freedesktop.org
Cc: "David Lechner" <david@lechnology.com>,
"Noralf Trønnes" <noralf@tronnes.org>,
"David Airlie" <airlied@linux.ie>,
linux-kernel@vger.kernel.org
Subject: [PATCH] drm/tinydrm: mipi-dbi: Fix unbalanced DMA access
Date: Tue, 1 Aug 2017 15:14:26 -0500 [thread overview]
Message-ID: <1501618466-32191-1-git-send-email-david@lechnology.com> (raw)
If we return here and import_attach is true, then dma_buf_end_cpu_access()
will not be called balance dma_buf_begin_cpu_access().
Fix by setting ret instead of returning.
Signed-off-by: David Lechner <david@lechnology.com>
---
drivers/gpu/drm/tinydrm/mipi-dbi.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/tinydrm/mipi-dbi.c b/drivers/gpu/drm/tinydrm/mipi-dbi.c
index c83eeb7..e10fa4b 100644
--- a/drivers/gpu/drm/tinydrm/mipi-dbi.c
+++ b/drivers/gpu/drm/tinydrm/mipi-dbi.c
@@ -183,7 +183,8 @@ static int mipi_dbi_buf_copy(void *dst, struct drm_framebuffer *fb,
dev_err_once(fb->dev->dev, "Format is not supported: %s\n",
drm_get_format_name(fb->format->format,
&format_name));
- return -EINVAL;
+ ret = -EINVAL;
+ break;
}
if (import_attach)
--
2.7.4
next reply other threads:[~2017-08-01 20:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-01 20:14 David Lechner [this message]
2017-08-02 18:51 ` Noralf Trønnes
2017-08-03 22:41 ` David Lechner
2017-08-04 6:49 ` Noralf Trønnes
2017-08-07 18:00 ` David Lechner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1501618466-32191-1-git-send-email-david@lechnology.com \
--to=david@lechnology.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=noralf@tronnes.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome