From: Arvind Yadav <arvind.yadav.cs@gmail.com>
To: mchehab@kernel.org, sakari.ailus@linux.intel.com, hverkuil@xs4all.nl
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 9/9] [media] saa7146: hexium_gemini: constify pci_device_id.
Date: Wed, 2 Aug 2017 22:44:57 +0530 [thread overview]
Message-ID: <1501694097-16207-10-git-send-email-arvind.yadav.cs@gmail.com> (raw)
In-Reply-To: <1501694097-16207-1-git-send-email-arvind.yadav.cs@gmail.com>
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <media/drv-intf/saa7146.h>
and <linux/pci.h> work with const pci_device_id. So mark the non-const
structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/media/pci/saa7146/hexium_gemini.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/pci/saa7146/hexium_gemini.c b/drivers/media/pci/saa7146/hexium_gemini.c
index c889ec9..f708cab 100644
--- a/drivers/media/pci/saa7146/hexium_gemini.c
+++ b/drivers/media/pci/saa7146/hexium_gemini.c
@@ -363,7 +363,7 @@ static struct saa7146_pci_extension_data hexium_gemini_dual_4bnc = {
.ext = &hexium_extension,
};
-static struct pci_device_id pci_tbl[] = {
+static const struct pci_device_id pci_tbl[] = {
{
.vendor = PCI_VENDOR_ID_PHILIPS,
.device = PCI_DEVICE_ID_PHILIPS_SAA7146,
--
2.7.4
prev parent reply other threads:[~2017-08-02 17:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-02 17:14 [PATCH 0/9] constify media pci_device_id/pci_tbl Arvind Yadav
2017-08-02 17:14 ` [PATCH 1/9] [media] drv-intf: saa7146: constify pci_device_id Arvind Yadav
2017-08-02 17:14 ` [PATCH 2/9] [media] ttpci: budget: " Arvind Yadav
2017-08-02 17:14 ` [PATCH 3/9] [media] ttpci: budget-patch: " Arvind Yadav
2017-08-02 17:14 ` [PATCH 4/9] [media] ttpci: budget-ci: " Arvind Yadav
2017-08-02 17:14 ` [PATCH 5/9] [media] ttpci: budget-av: " Arvind Yadav
2017-08-02 17:14 ` [PATCH 6/9] [media] ttpci: av7110: " Arvind Yadav
2017-08-02 17:14 ` [PATCH 7/9] [media] saa7146: mxb: " Arvind Yadav
2017-08-02 17:14 ` [PATCH 8/9] [media] saa7146: hexium_orion: " Arvind Yadav
2017-08-02 17:14 ` Arvind Yadav [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1501694097-16207-10-git-send-email-arvind.yadav.cs@gmail.com \
--to=arvind.yadav.cs@gmail.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®