From: Sean Wang <sean.wang@mediatek.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: <robh+dt@kernel.org>, <gregkh@linuxfoundation.org>,
<jslaby@suse.com>, <jan.kiszka@siemens.com>,
<heikki.krogerus@linux.intel.com>, <hpeter@gmail.com>,
<vigneshr@ti.com>, <matthias.bgg@gmail.com>,
<devicetree@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>,
<linux-serial@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/2] serial: 8250: add support for MediaTek BTIF controller
Date: Thu, 3 Aug 2017 01:37:50 +0800 [thread overview]
Message-ID: <1501695470.25246.7.camel@mtkswgap22> (raw)
In-Reply-To: <1501694063.29303.361.camel@linux.intel.com>
On Wed, 2017-08-02 at 20:14 +0300, Andy Shevchenko wrote:
> On Thu, 2017-08-03 at 01:05 +0800, sean.wang@mediatek.com wrote:
> > From: Sean Wang <sean.wang@mediatek.com>
> >
> > This patchset introduces the support for MediaTek BTIF controller.
> >
> > MediaTek BTIF controller is the serial interface similar to UART but
> > it
> > works only as the digital device which is mainly used to communicate
> > with
> > the connectivity module also called CONNSYS inside the SoC which could
> > be
> > mostly found on those MediaTek SoCs with Bluetooth feature.
> >
> > And the controller is made as being compatible with the 8250 register
> > layout so it tends to be integrated with existing 8250 core driver and
> > have no requirement for the modem configuration additionally such as
> > the
> > baud rate calculation and assignment.
>
>
> Why it requires a separate driver?
>
> 8250_of is for DT enabled drivers.
>
Hi, Andy
thanks for your information
the hardware is not completely identical to 8250 device,
it has extra registers belonged to platform control such as internal
loopback, dma disable/enable, sleep/wakeup setup and so on, so I create
it as a separate driver.
Sean
> >
> > Sean Wang (2):
> > dt-bindings: serial: Add MediaTek BTIF controller bindings
> > tty: serial: 8250: Add MediaTek BTIF controller on MT7622 and MT7623
> > SoC
> >
> > .../devicetree/bindings/serial/mtk-btif.txt | 26 +++
> > drivers/tty/serial/8250/8250_btif.c | 224
> > +++++++++++++++++++++
> > drivers/tty/serial/8250/Kconfig | 9 +
> > drivers/tty/serial/8250/Makefile | 1 +
> > 4 files changed, 260 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/serial/mtk-
> > btif.txt
> > create mode 100644 drivers/tty/serial/8250/8250_btif.c
> >
>
next prev parent reply other threads:[~2017-08-02 17:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-02 17:05 sean.wang
2017-08-02 17:05 ` [PATCH 1/2] dt-bindings: serial: Add MediaTek BTIF controller bindings sean.wang
2017-08-10 16:27 ` Rob Herring
2017-08-11 2:53 ` Sean Wang
2017-08-11 14:31 ` Rob Herring
2017-08-02 17:05 ` [PATCH 2/2] tty: serial: 8250: Add MediaTek BTIF controller on MT7622 and MT7623 SoC sean.wang
2017-08-02 17:14 ` [PATCH 0/2] serial: 8250: add support for MediaTek BTIF controller Andy Shevchenko
2017-08-02 17:37 ` Sean Wang [this message]
2017-08-02 18:02 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1501695470.25246.7.camel@mtkswgap22 \
--to=sean.wang@mediatek.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=hpeter@gmail.com \
--cc=jan.kiszka@siemens.com \
--cc=jslaby@suse.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome