mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vikas Shivappa <vikas.shivappa@linux.intel.com>
To: vikas.shivappa@intel.com
Cc: vikas.shivappa@linux.intel.com, x86@kernel.org,
	linux-kernel@vger.kernel.org, hpa@zytor.com, tglx@linutronix.de,
	peterz@infradead.org, ravi.v.shankar@intel.com,
	tony.luck@intel.com, fenghua.yu@intel.com, eranian@google.com,
	davidcc@google.com, ak@linux.intel.com,
	sai.praneeth.prakhya@intel.com
Subject: [PATCH 1/3] x86/intel_rdt/cqm: Add fix to clear the default RMID during hotcpu
Date: Wed,  9 Aug 2017 11:46:33 -0700	[thread overview]
Message-ID: <1502304395-7166-2-git-send-email-vikas.shivappa@linux.intel.com> (raw)
In-Reply-To: <1502304395-7166-1-git-send-email-vikas.shivappa@linux.intel.com>

The user configured per cpu default RMID is not cleared during cpu
hotplug. This may lead to incorrect RMID values after a cpu goes offline
and again comes back online. Clear the per cpu default RMID during cpu
offline and online handling.

Reported-by: Prakyha Sai Praneeth <sai.praneeth.prakhya@intel.com>
Signed-off-by: Vikas Shivappa <vikas.shivappa@linux.intel.com>
---
 arch/x86/kernel/cpu/intel_rdt.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/x86/kernel/cpu/intel_rdt.c b/arch/x86/kernel/cpu/intel_rdt.c
index da4f389..4b9edb2 100644
--- a/arch/x86/kernel/cpu/intel_rdt.c
+++ b/arch/x86/kernel/cpu/intel_rdt.c
@@ -551,6 +551,7 @@ static void clear_closid_rmid(int cpu)
 	struct intel_pqr_state *state = this_cpu_ptr(&pqr_state);
 
 	per_cpu(rdt_cpu_default.closid, cpu) = 0;
+	per_cpu(rdt_cpu_default.rmid, cpu) = 0;
 	state->closid = 0;
 	state->rmid = 0;
 	wrmsr(IA32_PQR_ASSOC, 0, 0);
-- 
1.9.1

  reply	other threads:[~2017-08-09 18:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-09 18:46 [PATCH 0/3 V3] Cqm3 based on resctrl fs with MBM support Vikas Shivappa
2017-08-09 18:46 ` Vikas Shivappa [this message]
2017-08-14  9:52   ` [tip:x86/cache] x86/intel_rdt/cqm: Clear the default RMID during hotcpu tip-bot for Vikas Shivappa
2017-08-09 18:46 ` [PATCH 2/3] x86/intel_rdt: Modify the intel_pqr_state for better performance Vikas Shivappa
2017-08-14  9:52   ` [tip:x86/cache] " tip-bot for Vikas Shivappa
2017-08-09 18:46 ` [PATCH 3/3] x86/intel_rdt/cqm: Improve limbo list processing Vikas Shivappa
2017-08-14  9:45   ` Thomas Gleixner
2017-08-14 19:16     ` Shivappa Vikas
2017-08-14 21:17       ` Shivappa Vikas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1502304395-7166-2-git-send-email-vikas.shivappa@linux.intel.com \
    --to=vikas.shivappa@linux.intel.com \
    --cc=ak@linux.intel.com \
    --cc=davidcc@google.com \
    --cc=eranian@google.com \
    --cc=fenghua.yu@intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=ravi.v.shankar@intel.com \
    --cc=sai.praneeth.prakhya@intel.com \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    --cc=vikas.shivappa@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome