From: Tyler Hicks <tyhicks@canonical.com>
To: Kees Cook <keescook@chromium.org>
Cc: Andy Lutomirski <luto@amacapital.net>,
Will Drewry <wad@chromium.org>, Paul Moore <paul@paul-moore.com>,
Eric Paris <eparis@redhat.com>, John Crispin <john@phrozen.org>,
Tycho Andersen <tycho@docker.com>,
linux-audit@redhat.com, linux-kernel@vger.kernel.org,
linux-api@vger.kernel.org
Subject: [PATCH v6 0/6] Improved seccomp logging
Date: Fri, 11 Aug 2017 04:33:51 +0000 [thread overview]
Message-ID: <1502426037-3777-1-git-send-email-tyhicks@canonical.com> (raw)
This patch set aims to improve logging in seccomp by:
1) Empowering administrators to be able to permit or quiet logging of
specific seccomp actions
2) Allowing applications to request logging of all actions, except for
RET_ALLOW, in the filter being loaded (subject to the
administrator's wishes in #1)
3) By making it possible for application developers to request logging
of specific syscalls while developing filters for their application
(subject to the administrator's wishes in #1)
With this patch set applied, the logic for deciding if an action will be
logged is as described in the commit message of the final patch.
* Changes since v5:
- Rebase onto
https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git/?h=seccomp/kill_process
(kees)
+ Redefine the value of SECCOMP_FILTER_FLAG_LOG to account for the
new SECCOMP_FILTER_FLAG_KILL_PROCESS
+ Add SECCOMP_FILTER_FLAG_KILL_PROCESS to the
detect_seccomp_filter_flags selftest
- Reorder patches to move SECCOMP_GET_ACTION_AVAIL patch behind
actions_avail sysctl patch (kees)
- Reorder patches to move the selftest to detect filter flag support
before the patch that adds SECCOMP_FILTER_FLAG_LOG (kees)
- Add psuedo code showing the high level logic of when and when not to
log to the commit message of each patch that changes the logging
behavior (inspired by kees)
- Add Suggested-by to the SECCOMP_GET_ACTION_AVAIL patch to credit
Andy for the idea (tyhicks)
- Use sizeof(seccomp_actions_avail), instead of strlen(), to avoid
variable length "names" array in seccomp_actions_logged_handler()
(smatch)
- Only check the actions_logged sysctl value for "kill" when first
introducing the actions_logged sysctl since filters cannot yet set
the FILTER_FLAG_LOG flag (kees)
- Mention how the actions_logged sysctl could quiet SECCOMP_RET_LOG
actions in seccomp_filter.rst documentation (kees)
Tyler
next reply other threads:[~2017-08-11 4:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-11 4:33 Tyler Hicks [this message]
2017-08-11 4:33 ` [PATCH v6 1/6] seccomp: Sysctl to display available actions Tyler Hicks
2017-08-11 4:33 ` [PATCH v6 2/6] seccomp: Operation for checking if an action is available Tyler Hicks
2017-08-11 4:33 ` [PATCH v6 3/6] seccomp: Sysctl to configure actions that are allowed to be logged Tyler Hicks
2017-08-11 19:17 ` Kees Cook
2017-08-11 19:33 ` Tyler Hicks
2017-08-11 19:35 ` Kees Cook
2017-08-11 4:33 ` [PATCH v6 4/6] seccomp: Selftest for detection of filter flag support Tyler Hicks
2017-08-11 4:33 ` [PATCH v6 5/6] seccomp: Filter flag to log all actions except SECCOMP_RET_ALLOW Tyler Hicks
2017-08-11 4:33 ` [PATCH v6 6/6] seccomp: Action to log before allowing Tyler Hicks
2017-08-11 19:14 ` [PATCH v6 0/6] Improved seccomp logging Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1502426037-3777-1-git-send-email-tyhicks@canonical.com \
--to=tyhicks@canonical.com \
--cc=eparis@redhat.com \
--cc=john@phrozen.org \
--cc=keescook@chromium.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-audit@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=paul@paul-moore.com \
--cc=tycho@docker.com \
--cc=wad@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®