From: Thierry Escande <thierry.escande@collabora.com>
To: Benson Leung <bleung@chromium.org>,
Lee Jones <lee.jones@linaro.org>,
Jonathan Cameron <jic23@kernel.org>
Cc: Joseph Lo <josephl@nvidia.com>,
Gwendal Grignou <gwendal@chromium.org>,
Douglas Anderson <dianders@chromium.org>,
Daniel Hung-yu Wu <hywu@google.com>,
Vincent Palatin <vpalatin@chromium.org>,
Wei-Ning Huang <wnhuang@google.com>,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org
Subject: [PATCH v2 4/8] platform/chrome: cros_ec: register shutdown function for debugfs
Date: Fri, 11 Aug 2017 16:23:01 +0200 [thread overview]
Message-ID: <1502461385-27564-5-git-send-email-thierry.escande@collabora.com> (raw)
In-Reply-To: <1502461385-27564-1-git-send-email-thierry.escande@collabora.com>
From: Daniel Hung-yu Wu <hywu@google.com>
Reboot or shutdown during delayed works could corrupt communication with
EC and certain I2C controller may not be able to recover from the error
state.
This patch registers a shutdown callback used to cancel the debugfs log
worker thread.
Signed-off-by: Daniel Hung-yu Wu <hywu@chromium.org>
Signed-off-by: Thierry Escande <thierry.escande@collabora.com>
---
drivers/platform/chrome/cros_ec_dev.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/platform/chrome/cros_ec_dev.c b/drivers/platform/chrome/cros_ec_dev.c
index 2571f5e..225d8e9 100644
--- a/drivers/platform/chrome/cros_ec_dev.c
+++ b/drivers/platform/chrome/cros_ec_dev.c
@@ -460,6 +460,14 @@ static int ec_device_remove(struct platform_device *pdev)
return 0;
}
+static void ec_device_shutdown(struct platform_device *pdev)
+{
+ struct cros_ec_dev *ec = dev_get_drvdata(&pdev->dev);
+
+ /* Be sure to clear up debugfs delayed works */
+ cros_ec_debugfs_remove(ec);
+}
+
static const struct platform_device_id cros_ec_id[] = {
{ "cros-ec-ctl", 0 },
{ /* sentinel */ },
@@ -502,6 +510,7 @@ static struct platform_driver cros_ec_dev_driver = {
},
.probe = ec_device_probe,
.remove = ec_device_remove,
+ .shutdown = ec_device_shutdown,
};
static int __init cros_ec_dev_init(void)
--
2.7.4
next prev parent reply other threads:[~2017-08-11 14:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-11 14:22 [PATCH v2 0/8] platform/chrome: cros_ec: Fixes and improvements Thierry Escande
2017-08-11 14:22 ` [PATCH v2 1/8] iio: cros_ec: Relax sampling frequency before suspending Thierry Escande
2017-08-12 12:42 ` Jonathan Cameron
2017-08-11 14:22 ` [PATCH v2 2/8] mfd: cros_ec_i2c: move the system sleep pm ops to late Thierry Escande
2017-08-11 14:23 ` [PATCH v2 3/8] mfd: cros_ec: Stop the debugfs work when suspended Thierry Escande
2017-08-15 6:31 ` Benson Leung
2017-08-11 14:23 ` Thierry Escande [this message]
2017-08-15 6:35 ` [PATCH v2 4/8] platform/chrome: cros_ec: register shutdown function for debugfs Benson Leung
2017-08-11 14:23 ` [PATCH v2 5/8] mfd: cros_ec: fail early if we cannot identify the EC Thierry Escande
2017-08-11 14:23 ` [PATCH v2 6/8] mfd: cros_ec_i2c: add ACPI module device table Thierry Escande
2017-08-11 14:23 ` [PATCH v2 7/8] platform/chrome: cros_ec: Add sysfs entry to set keyboard wake lid angle Thierry Escande
2017-09-11 19:39 ` Benson Leung
2017-08-11 14:23 ` [PATCH v2 8/8] platform/chrome: cros_ec: sysfs: Modify error handling Thierry Escande
2017-09-11 19:42 ` Benson Leung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1502461385-27564-5-git-send-email-thierry.escande@collabora.com \
--to=thierry.escande@collabora.com \
--cc=bleung@chromium.org \
--cc=dianders@chromium.org \
--cc=gwendal@chromium.org \
--cc=hywu@google.com \
--cc=jic23@kernel.org \
--cc=josephl@nvidia.com \
--cc=lee.jones@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vpalatin@chromium.org \
--cc=wnhuang@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®