From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751972AbdHLAog (ORCPT ); Fri, 11 Aug 2017 20:44:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:43624 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751361AbdHLAof (ORCPT ); Fri, 11 Aug 2017 20:44:35 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4914522BCC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=mhiramat@kernel.org From: Masami Hiramatsu To: Ingo Molnar Cc: Ingo Molnar , "H . Peter Anvin" , x86@kernel.org, Masami Hiramatsu , Ananth N Mavinakayanahalli , Anil S Keshavamurthy , "David S . Miller" , linux-kernel@vger.kernel.org Subject: [PATCH -tip v2 0/2] kprobes/x86: RO text code bugfix and cleanup Date: Sat, 12 Aug 2017 09:43:43 +0900 Message-Id: <150249861299.18166.13400123503538960282.stgit@devbox> X-Mailer: git-send-email 2.13.4 User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, This series fixes a kprobe-x86 bug related to RO text and cleans up addressof operators. The first one is an obvious bug that misses to set memory RO when the function fails. And the second one is just a cleanup patch to remove addressof operators ("&") since it is meaningless anymore. V2 has just a following update: - [1/2] Use a helper variable instead of using p->ainsn.insn directly. Thanks, --- Masami Hiramatsu (2): kprobes/x86: Don't forget to set memory back to RO on failure kprobes/x86: Remove addressof operators arch/x86/include/asm/kprobes.h | 4 ++-- arch/x86/kernel/kprobes/core.c | 15 +++++++++------ arch/x86/kernel/kprobes/opt.c | 9 +++++---- 3 files changed, 16 insertions(+), 12 deletions(-) -- Masami Hiramatsu