From: "Pali Rohár" <pali.rohar@gmail.com>
To: Corentin Chary <corentin.chary@gmail.com>,
Darren Hart <dvhart@infradead.org>,
Andy Shevchenko <andy@infradead.org>
Cc: acpi4asus-user@lists.sourceforge.net,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, "Pali Rohár" <pali.rohar@gmail.com>,
"Hans de Goede" <hdegoede@redhat.com>
Subject: [PATCH 3/4] platform/x86: peaq-wmi: Evaluate wmi method with instance number 0x0
Date: Sat, 12 Aug 2017 09:44:17 +0200 [thread overview]
Message-ID: <1502523858-25716-4-git-send-email-pali.rohar@gmail.com> (raw)
In-Reply-To: <1502523858-25716-1-git-send-email-pali.rohar@gmail.com>
According to Hans de Goede, WMI interface of thh peaq-wmi module has 10
instances but corresponding ACPI WMBC method does not check Arg0 (instance
number) at all. Therefore evaluate WMI method with first instance number
(0x0) instead of second (0x1).
Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
Cc: Hans de Goede <hdegoede@redhat.com>
---
drivers/platform/x86/peaq-wmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/peaq-wmi.c b/drivers/platform/x86/peaq-wmi.c
index 77d1f90..f59a5a2 100644
--- a/drivers/platform/x86/peaq-wmi.c
+++ b/drivers/platform/x86/peaq-wmi.c
@@ -39,7 +39,7 @@ static void peaq_wmi_poll(struct input_polled_dev *dev)
struct acpi_buffer input = { sizeof(dummy), &dummy };
struct acpi_buffer output = { sizeof(obj), &obj };
- status = wmi_evaluate_method(PEAQ_DOLBY_BUTTON_GUID, 1,
+ status = wmi_evaluate_method(PEAQ_DOLBY_BUTTON_GUID, 0,
PEAQ_DOLBY_BUTTON_METHOD_ID,
&input, &output);
if (ACPI_FAILURE(status))
--
1.7.9.5
next prev parent reply other threads:[~2017-08-12 7:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-12 7:44 [PATCH 0/4] platform/x86: Fix check for method instance number Pali Rohár
2017-08-12 7:44 ` [PATCH 1/4] platform/x86: mxm-wmi: Evaluate wmi method with instance number 0x0 Pali Rohár
2017-08-12 7:44 ` [PATCH 2/4] platform/x86: asus-wmi: " Pali Rohár
2017-08-12 7:44 ` Pali Rohár [this message]
2017-08-12 20:12 ` [PATCH 3/4] platform/x86: peaq-wmi: " Hans de Goede
2017-08-12 7:44 ` [PATCH 4/4] platform/x86: wmi: Fix check for method instance number Pali Rohár
2017-08-17 15:24 ` Darren Hart
2017-08-17 21:13 ` Pali Rohár
2017-08-17 21:36 ` Darren Hart
2017-08-18 12:20 ` Andy Shevchenko
2017-08-13 12:54 ` [PATCH 0/4] platform/x86: " Andy Shevchenko
2017-08-17 15:25 ` Darren Hart
2017-08-17 17:31 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1502523858-25716-4-git-send-email-pali.rohar@gmail.com \
--to=pali.rohar@gmail.com \
--cc=acpi4asus-user@lists.sourceforge.net \
--cc=andy@infradead.org \
--cc=corentin.chary@gmail.com \
--cc=dvhart@infradead.org \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®