mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Zihan Xi <zihanx@nebusec.ai>
Cc: dhowells@redhat.com, netdev@vger.kernel.org,
	Marc Dionne <marc.dionne@auristor.com>,
	"David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Simon Horman <horms@kernel.org>,
	linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH net v3 1/1] rxrpc: fix encap_rcv skb accounting exhaustion
Date: Tue, 08 Sep 2026 09:25:07 +0100	[thread overview]
Message-ID: <1502561.1788855907@warthog.procyon.org.uk> (raw)
In-Reply-To: <a2bd6f3ed29919a7328363b548299ae583f052b0.1788539302.git.zihanx@nebusec.ai>

Zihan Xi <zihanx@nebusec.ai> wrote:

> Reaccount encapsulated packets against the UDP socket before queueing
> them on the RxRPC local queue and drop packets once the socket rcvbuf
> limit is reached.

This seems reasonable.  I do really need to add separate accounting for
buffered incoming DATA packets and for all other incoming packets (especially
ACKs), but I think that can be done after the skb_orphan() point you add.

> Clear sk_user_data under RCU protection and release the socket only after
> the local queues are purged.

Is this actually a fix for a separate issue?

Anyway:

Acked-by: David Howells <dhowells@redhat.com>


  parent reply	other threads:[~2026-09-08  8:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-05  8:17 [PATCH net v3 0/1] " Zihan Xi
2026-09-05  8:17 ` [PATCH net v3 1/1] " Zihan Xi
2026-09-08 12:17   ` Simon Horman
2026-09-09  4:58     ` zihan xi
2026-09-08  8:25 ` David Howells [this message]
2026-09-08  9:12   ` zihan xi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1502561.1788855907@warthog.procyon.org.uk \
    --to=dhowells@redhat.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-afs@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marc.dionne@auristor.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=stable@vger.kernel.org \
    --cc=zihanx@nebusec.ai \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®