mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: James Simmons <jsimmons@infradead.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	devel@driverdev.osuosl.org,
	Andreas Dilger <andreas.dilger@intel.com>,
	Oleg Drokin <oleg.drokin@intel.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Lustre Development List <lustre-devel@lists.lustre.org>,
	James Simmons <jsimmons@infradead.org>,
	James Simmons <uja.ornl@yahoo.com>
Subject: [PATCH 13/14] staging: lustre: llite: style changes in xattr.c
Date: Mon, 14 Aug 2017 12:21:03 -0400	[thread overview]
Message-ID: <1502727664-29438-14-git-send-email-jsimmons@infradead.org> (raw)
In-Reply-To: <1502727664-29438-1-git-send-email-jsimmons@infradead.org>

Small style changes to match more the kernel code standard
and it make it more readable.

Signed-off-by: James Simmons <uja.ornl@yahoo.com>
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9183
Reviewed-on: https://review.whamcloud.com/27240
Reviewed-by: Dmitry Eremin <dmitry.eremin@intel.com>
Reviewed-by: Bob Glossman <bob.glossman@intel.com>
Reviewed-by: Sebastien Buisson <sbuisson@ddn.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: James Simmons <jsimmons@infradead.org>
---
 drivers/staging/lustre/lustre/llite/xattr.c | 20 +++++++++-----------
 1 file changed, 9 insertions(+), 11 deletions(-)

diff --git a/drivers/staging/lustre/lustre/llite/xattr.c b/drivers/staging/lustre/lustre/llite/xattr.c
index adaff56..0f5271a 100644
--- a/drivers/staging/lustre/lustre/llite/xattr.c
+++ b/drivers/staging/lustre/lustre/llite/xattr.c
@@ -81,11 +81,10 @@ static int xattr_type_filter(struct ll_sb_info *sbi,
 	return 0;
 }
 
-static int
-ll_xattr_set_common(const struct xattr_handler *handler,
-		    struct dentry *dentry, struct inode *inode,
-		    const char *name, const void *value, size_t size,
-		    int flags)
+static int ll_xattr_set_common(const struct xattr_handler *handler,
+			       struct dentry *dentry, struct inode *inode,
+			       const char *name, const void *value, size_t size,
+			       int flags)
 {
 	struct ll_sb_info *sbi = ll_i2sbi(inode);
 	struct ptlrpc_request *req = NULL;
@@ -140,9 +139,8 @@ static int xattr_type_filter(struct ll_sb_info *sbi,
 	if (!fullname)
 		return -ENOMEM;
 
-	rc = md_setxattr(sbi->ll_md_exp, ll_inode2fid(inode),
-			 valid, fullname, pv, size, 0, flags,
-			 ll_i2suppgid(inode), &req);
+	rc = md_setxattr(sbi->ll_md_exp, ll_inode2fid(inode), valid, fullname,
+			 pv, size, 0, flags, ll_i2suppgid(inode), &req);
 	kfree(fullname);
 	if (rc) {
 		if (rc == -EOPNOTSUPP && handler->flags == XATTR_USER_T) {
@@ -308,9 +306,8 @@ static int ll_xattr_set(const struct xattr_handler *handler,
 				   flags);
 }
 
-int
-ll_xattr_list(struct inode *inode, const char *name, int type, void *buffer,
-	      size_t size, u64 valid)
+int ll_xattr_list(struct inode *inode, const char *name, int type, void *buffer,
+		  size_t size, u64 valid)
 {
 	struct ll_inode_info *lli = ll_i2info(inode);
 	struct ll_sb_info *sbi = ll_i2sbi(inode);
@@ -565,6 +562,7 @@ ssize_t ll_listxattr(struct dentry *dentry, char *buffer, size_t size)
 			   OBD_MD_FLXATTRLS);
 	if (rc < 0)
 		return rc;
+
 	/*
 	 * If we're being called to get the size of the xattr list
 	 * (size == 0) then just assume that a lustre.lov xattr
-- 
1.8.3.1

  parent reply	other threads:[~2017-08-14 16:21 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-14 16:20 [PATCH 00/14] staging: lustre: llite: xattr related handling fixes James Simmons
2017-08-14 16:20 ` [PATCH v2 01/14] staging: lustre: llite: Remove filtering of seclabel xattr James Simmons
2017-08-17 16:23   ` Greg Kroah-Hartman
2017-08-20  2:53     ` James Simmons
2017-08-14 16:20 ` [PATCH 02/14] staging: lustre: llite: refactor lustre.lov xattr handling James Simmons
2017-08-14 16:20 ` [PATCH 03/14] staging: lustre: llite: add simple comment about lustre.lov xattrs James Simmons
2017-08-14 16:20 ` [PATCH 04/14] staging: lustre: llite: break up ll_setstripe_ea function James Simmons
2017-08-14 16:20 ` [PATCH 05/14] staging: lustre: llite: return from ll_adjust_lum() if lump is NULL James Simmons
2017-08-14 16:20 ` [PATCH 06/14] staging: lustre: llite: eat -EEXIST on setting trunsted.lov James Simmons
2017-08-14 16:20 ` [PATCH 07/14] staging: lustre: llite: fix sparse variable length array warning James Simmons
2017-08-14 16:20 ` [PATCH 08/14] staging: lustre: llite: fix invalid size test in ll_setstripe_ea() James Simmons
2017-08-14 16:20 ` [PATCH 09/14] staging: lustre: llite: record in stats attempted removal of lma/link xattr James Simmons
2017-08-14 16:21 ` [PATCH 10/14] staging: lustre: llite: cleanup posix acl xattr code James Simmons
2017-08-14 16:21 ` [PATCH 11/14] staging: lustre: llite: use proper types in the " James Simmons
2017-08-14 16:21 ` [PATCH 12/14] staging: lustre: llite: cleanup xattr code comments James Simmons
2017-08-14 16:21 ` James Simmons [this message]
2017-08-14 16:21 ` [PATCH 14/14] staging: lustre: llite: add support set_acl method in inode operations James Simmons

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1502727664-29438-14-git-send-email-jsimmons@infradead.org \
    --to=jsimmons@infradead.org \
    --cc=andreas.dilger@intel.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lustre-devel@lists.lustre.org \
    --cc=oleg.drokin@intel.com \
    --cc=uja.ornl@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®