mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arvind Yadav <arvind.yadav.cs@gmail.com>
To: perex@perex.cz, tiwai@suse.com, dhowells@redhat.com
Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org
Subject: [PATCH 02/15] ALSA: es18xx: constify pnp_device_id and pnp_card_device_id
Date: Thu, 17 Aug 2017 15:36:17 +0530	[thread overview]
Message-ID: <1502964390-6927-3-git-send-email-arvind.yadav.cs@gmail.com> (raw)
In-Reply-To: <1502964390-6927-1-git-send-email-arvind.yadav.cs@gmail.com>

*_device_id are not supposed to change at runtime. All functions
working with *_device_id provided by <linux/pnp.h> work with
const *_device_id. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 sound/isa/es18xx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/isa/es18xx.c b/sound/isa/es18xx.c
index ae17a65..5d4a30a 100644
--- a/sound/isa/es18xx.c
+++ b/sound/isa/es18xx.c
@@ -2017,7 +2017,7 @@ static int isa_registered;
 static int pnp_registered;
 static int pnpc_registered;
 
-static struct pnp_device_id snd_audiodrive_pnpbiosids[] = {
+static const struct pnp_device_id snd_audiodrive_pnpbiosids[] = {
 	{ .id = "ESS1869" },
 	{ .id = "ESS1879" },
 	{ .id = "" }		/* end */
@@ -2062,7 +2062,7 @@ static int snd_audiodrive_pnp(int dev, struct snd_es18xx *chip,
 	return 0;
 }
 
-static struct pnp_card_device_id snd_audiodrive_pnpids[] = {
+static const struct pnp_card_device_id snd_audiodrive_pnpids[] = {
 	/* ESS 1868 (integrated on Compaq dual P-Pro motherboard and Genius 18PnP 3D) */
 	{ .id = "ESS1868", .devs = { { "ESS1868" }, { "ESS0000" } } },
 	/* ESS 1868 (integrated on Maxisound Cards) */
-- 
2.7.4

  parent reply	other threads:[~2017-08-17 10:10 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-17 10:06 [PATCH 00/15] " Arvind Yadav
2017-08-17 10:06 ` [PATCH 01/15] ALSA: drivers: mpu401: constify pnp_device_id Arvind Yadav
2017-08-17 10:06 ` Arvind Yadav [this message]
2017-08-17 10:06 ` [PATCH 03/15] ALSA: opl3sa2: constify pnp_device_id and pnp_card_device_id Arvind Yadav
2017-08-17 10:06 ` [PATCH 04/15] ALSA: ad1816a: constify pnp_card_device_id Arvind Yadav
2017-08-17 10:06 ` [PATCH 05/15] ALSA: als100: " Arvind Yadav
2017-08-17 10:06 ` [PATCH 06/15] ALSA: azt2320: " Arvind Yadav
2017-08-17 10:06 ` [PATCH 07/15] ALSA: cmi8330: " Arvind Yadav
2017-08-17 10:06 ` [PATCH 08/15] ALSA: cs4236: " Arvind Yadav
2017-08-17 10:06 ` [PATCH 09/15] ALSA: es1688: " Arvind Yadav
2017-08-17 10:06 ` [PATCH 10/15] ALSA: gus: " Arvind Yadav
2017-08-17 10:06 ` [PATCH 11/15] ALSA: msnd: " Arvind Yadav
2017-08-17 10:06 ` [PATCH 12/15] ALSA: opti9xx: " Arvind Yadav
2017-08-17 10:06 ` [PATCH 13/15] ALSA: sb16: " Arvind Yadav
2017-08-17 10:06 ` [PATCH 14/15] ALSA: sscape: " Arvind Yadav
2017-08-17 10:06 ` [PATCH 15/15] ALSA: wavefront: " Arvind Yadav
2017-08-17 10:48 ` [PATCH 00/15] constify pnp_device_id and pnp_card_device_id Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1502964390-6927-3-git-send-email-arvind.yadav.cs@gmail.com \
    --to=arvind.yadav.cs@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=dhowells@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®