From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756090AbbLAQpa (ORCPT <rfc822;w@1wt.eu>);
	Tue, 1 Dec 2015 11:45:30 -0500
Received: from mout.kundenserver.de ([212.227.126.135]:57158 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755823AbbLAQp2 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 1 Dec 2015 11:45:28 -0500
From: Arnd Bergmann <arnd@arndb.de>
To: Mark Brown <broonie@kernel.org>
Cc: Thierry Reding <treding@nvidia.com>, linux-kernel@vger.kernel.org,
        Tyler Baker <tyler.baker@linaro.org>
Subject: Re: [PATCH] regulator: core: Ensure we lock all regulators
Date: Tue, 01 Dec 2015 17:45:17 +0100
Message-ID: <1503180.zM1PdPxpk1@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <1448988057-13965-1-git-send-email-broonie@kernel.org>
References: <1448988057-13965-1-git-send-email-broonie@kernel.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:OwUyGanTQWC54M6AGbBLN9T0CDOJuU44jdsYBy6UUVQP3BQHEoK
 GE4MVLK6493Ugal2/AGGGRjtJP0+1jlUOMFRqBT/pdO70e5Q3UxRIJldGBdex2Ue154UT+K
 3MfMePAvTdyEL1dMaDRDTZWYy3uy639gne6IaAMbekqsn7wpLn8DNbbja0pLYwpOHrDkUKV
 c4b+A+IHmmHDVkdkOv2hQ==
X-UI-Out-Filterresults: notjunk:1;V01:K0:dlg51XY0TFM=:k8zIjpa7TyUZQr5SzjuUtw
 Yg6w9QWqRwGlq889oaL9Q9N0KTisPzNlWeRSvX2AIFNEmMFYqECu5BZPr/v0y4QXj81VOL0lO
 Tl9u1Kjyt7beBzPWfOOMVK6UxcvZkIClmu+P0/RC8W7QrXxUGpo4vBh5BfkREQNCijK99uPjN
 SV6CgqeeX1aqXaAYDoI5lK9EwR6Yu25X+y8VQ0juHV/XIDnvUILO0Vg4Jds2Dd2ColeF6EfgL
 xc7xD1cAwHzk6ruTD1PiEXDg9vIybgSTG1yhZRTfPbDvkXeHut0vyGrvADylkB0Unvj+/sJ0s
 JD2WV308PrkrO6F/wITVIzUNr6CuhWagWjqupq7CRiBRN4rw9qkX/jbIvIPT3wKM20uM2MpG7
 U3NyaF/CDV9DafIpHEjAgPg7I171w5F0sRsNj7Xq15XPhyaElDtPriM/xFB14e8wXPU6lyoq7
 AATlIkTheAyZv1pGYb7j9jnvcFuNPJ9Ra89y1fmP5Z73wIVG4pDoPNrMBIqTcoRtroZqXGPCc
 Mwp1zchGat32XuxAOYe5c0qd4FB5Wa6WQTq9c5z9q0ghb3fqQ7+3aVlQePXrBB3SUfYuaOjf5
 Yxn2qQkwoSAS7tAwbzqUibMvrh1U26FzFFwEJqh6I3JzAVzcK23G9nXN30zQRDdrDDd8UkcC6
 Y69enBsHAi0gn/b8AoR1B0DNSIOe71ghgYt8zYe8FDETjuYYrvynHI18NNbGEAkXdgDFWOndH
 H7u886FnfFnbxtEI
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tuesday 01 December 2015 16:40:57 Mark Brown wrote:
> diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
> index daffff83ced2..f71db02fcb71 100644
> --- a/drivers/regulator/core.c
> +++ b/drivers/regulator/core.c
> @@ -141,7 +141,7 @@ static void regulator_lock_supply(struct regulator_dev *rdev)
>         int i;
>  
>         mutex_lock(&rdev->mutex);
> -       for (i = 1; rdev->supply; rdev = rdev->supply->rdev, i++)
> +       for (i = 1; rdev; rdev = rdev->supply->rdev, i++)
>                 mutex_lock_nested(&rdev->mutex, i);
> 

I think now we have a double lock, the initial mutex_lock() needs to
be removed again.

	Arnd