mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vallish Vaidyeshwara <vallish@amazon.com>
To: <davem@davemloft.net>, <shuah@kernel.org>,
	<richardcochran@gmail.com>, <xiyou.wangcong@gmail.com>,
	<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc: <eduval@amazon.com>, <anchalag@amazon.com>, <vallish@amazon.com>
Subject: [PATCH v2 0/2] enable hires timer to timeout datagram socket
Date: Wed, 23 Aug 2017 00:10:25 +0000	[thread overview]
Message-ID: <1503447027-44399-1-git-send-email-vallish@amazon.com> (raw)

v1->v2:
 - Cong Wang pointed out MAX_SCHEDULE_TIMEOUT wraparound, fixed the
   patch 1/2 to accommodate MAX_SCHEDULE_TIMEOUT wait time
 - Changed format of printing total time from float to long in
   selftests patch 2/2

Hello Dave,

Resending the patch series to include netdev mailing list with a
cover letter.

I am submitting 2 patch series to enable hires timer to timeout
datagram sockets (AF_UNIX & AF_INET domain) and test code to test
timeout accuracy on these sockets.

There has been a behavior change in 4.9 kernel with refactoring of Kernel
timer wheel in 4.8. We have a use case wherein our datagram socket
application is sensitive to socket timeout including long timeouts.

One of the test runs with a timeout value of 180 seconds timed out at
190 seconds.
[root@]# ./datagram_sock_timeout 180000
datagram_sock_timeout failed: took 190.00 seconds
[root@]#
The same program when run on a 4.4 kernel would timeout more accurately and
the kernel added slack was not noticeable to user application.

Patch 1: Has core code change of enabling hires timer to timeout datagram
	 socket on AF_UNIX and AF_INET domain
	 Patch 2: Test code to report regression in timeout behavior related to
		 patch 1

Vallish Vaidyeshwara (2):
  net: enable high resolution timer mode to timeout datagram sockets
  selftests/net: add test to verify datagram socket timeout

 net/core/datagram.c                                |  14 ++-
 tools/testing/selftests/net/Makefile               |   3 +-
 .../testing/selftests/net/datagram_sock_timeout.c  | 119 +++++++++++++++++++++
 .../selftests/net/run_datagram_sock_timeout.sh     |  12 +++
 4 files changed, 146 insertions(+), 2 deletions(-)
 create mode 100644 tools/testing/selftests/net/datagram_sock_timeout.c
 create mode 100755 tools/testing/selftests/net/run_datagram_sock_timeout.sh

-- 
2.7.3.AMZN

             reply	other threads:[~2017-08-23  0:11 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-23  0:10 Vallish Vaidyeshwara [this message]
2017-08-23  0:10 ` [PATCH v2 1/2] net: enable high resolution timer mode to timeout datagram sockets Vallish Vaidyeshwara
2017-08-23  0:10 ` [PATCH v2 2/2] selftests/net: add test to verify datagram socket timeout Vallish Vaidyeshwara
2017-08-23  4:30 ` [PATCH v2 0/2] enable hires timer to timeout datagram socket David Miller
2017-08-27 20:47   ` Vallish Vaidyeshwara
2017-08-29 11:16     ` David Laight
2017-09-08 17:04   ` Eduardo Valentin
2017-09-08 17:16     ` David Miller
2017-09-08 17:23       ` David Woodhouse
2017-09-08 17:26         ` David Miller
2017-09-08 18:55           ` Eduardo Valentin
2017-09-08 19:11             ` Eric Dumazet
2017-09-16  9:47               ` Thomas Gleixner
2017-09-20 22:48                 ` Vallish Vaidyeshwara
2017-09-25 20:42                   ` Thomas Gleixner
2017-09-08 21:44             ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1503447027-44399-1-git-send-email-vallish@amazon.com \
    --to=vallish@amazon.com \
    --cc=anchalag@amazon.com \
    --cc=davem@davemloft.net \
    --cc=eduval@amazon.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=richardcochran@gmail.com \
    --cc=shuah@kernel.org \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®