From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "corbet@lwn.net" <corbet@lwn.net>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>
Subject: Re: [PATCH] driver core: Document struct device:dma_ops
Date: Thu, 24 Aug 2017 23:26:56 +0000 [thread overview]
Message-ID: <1503616763.2899.123.camel@wdc.com> (raw)
In-Reply-To: <20170824160910.43c9b643@lwn.net>
On Thu, 2017-08-24 at 16:09 -0600, Jonathan Corbet wrote:
> Commit 5657933dbb6e (treewide: Move dma_ops from struct dev_archdata into
> struct device) added the dma_ops field to struct device, but did not
> update the kerneldoc comment, yielding this warning:
>
> ./include/linux/device.h:969: warning: No description found for parameter 'dma_ops'
>
> Add a description and bring a little peace to the world.
>
> Signed-off-by: Jonathan Corbet <corbet@lwn.net>
> ---
> include/linux/device.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/device.h b/include/linux/device.h
> index 723cd54b94da..ed9904728cda 100644
> --- a/include/linux/device.h
> +++ b/include/linux/device.h
> @@ -847,6 +847,7 @@ struct dev_links_info {
> * @msi_list: Hosts MSI descriptors
> * @msi_domain: The generic MSI domain this device is using.
> * @numa_node: NUMA node this device is close to.
> + * @dma_ops: DMA mapping operations for this device.
> * @dma_mask: Dma mask (if dma'ble device).
> * @coherent_dma_mask: Like dma_mask, but for alloc_coherent mapping as not all
> * hardware supports 64-bit addresses for consistent allocations
Thanks Jonathan for this patch.
Reviewed-by: Bart Van Assche <bart.vanassche@wdc.com>
prev parent reply other threads:[~2017-08-24 23:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-24 22:09 Jonathan Corbet
2017-08-24 23:26 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1503616763.2899.123.camel@wdc.com \
--to=bart.vanassche@wdc.com \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®