From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751582AbdH1AAe (ORCPT <rfc822;w@1wt.eu>);
        Sun, 27 Aug 2017 20:00:34 -0400
Received: from out2-smtp.messagingengine.com ([66.111.4.26]:41595 "EHLO
        out2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1751484AbdH1AAc (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 27 Aug 2017 20:00:32 -0400
X-ME-Sender: <xms:HV2jWYo0LkhFJqEarGJsmalKTgE3EyF8szx8WoKajPnMxISBMy43Iw>
X-Sasl-enc: VD3JN3/zTowV28fw+2csLeCTaX+93rnTUeNUdH1qobxs 1503878428
Message-ID: <1503878419.32695.9.camel@aj.id.au>
Subject: Re: [PATCH 2/2] leds: gpio: Allow LED to retain state at shutdown
From: Andrew Jeffery <andrew@aj.id.au>
To: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Cc: Pavel Machek <pavel@ucw.cz>, linux-leds@vger.kernel.org,
        rpurdie@rpsys.net, robh+dt@kernel.org, mark.rutland@arm.com,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        joel@jms.id.au, openbmc@lists.ozlabs.org
Date: Mon, 28 Aug 2017 09:30:19 +0930
In-Reply-To: <3b89ad70-7024-b4ac-bf4e-49a02d12da51@gmail.com>
References: <20170825063503.31577-1-andrew@aj.id.au>
         <20170825063503.31577-3-andrew@aj.id.au> <20170825073239.GB15494@amd>
         <3b89ad70-7024-b4ac-bf4e-49a02d12da51@gmail.com>
Content-Type: multipart/signed; micalg="pgp-sha512";
        protocol="application/pgp-signature"; boundary="=-uxUCu/RNPok7omOLWy6A"
X-Mailer: Evolution 3.22.6-1ubuntu1 
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


--=-uxUCu/RNPok7omOLWy6A
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Jacek, Pavel

On Sun, 2017-08-27 at 13:01 +0200, Jacek Anaszewski wrote:
> Hi Andrew,
>=20
> On 08/25/2017 09:32 AM, Pavel Machek wrote:
> > On Fri 2017-08-25 16:05:03, Andrew Jeffery wrote:
> > > In some systems, such as BMCs, we want to retain the state of LEDs
> > > across a reboot of the BMC whilst the host remains up.
> >=20
> > I'd spell out what BMC is...
>=20
> I agree with Pavel. Please give the expansion of the acronym
> in both DT patch and the driver commit message.

No worries, will reword and resend.

Thanks for the review.

Andrew

>=20
> >=20
> > Otherwise series looks good.
> >=20
> > Acked-by: Pavel Machek <pavel@ucw.cz>
>=20
>=20
--=-uxUCu/RNPok7omOLWy6A
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iQIcBAABCgAGBQJZo10TAAoJEJ0dnzgO5LT5rB8QAKaheT4+T4uH++dwNNuXJ5DP
PIFclCZ9oaFSkzyyMRecNMcifRRnhtMnQdlnOkQBzCaq10OxPFGKin/wr8BoANMw
Z4Y6wM90XuTJEayg1b/4Cf35zDEpXr+SJTNvXsf8VootjkAysK5Y+2yLSORbf9tG
v6ayMPmek4CYYMzZrDi1vlyFYJvKFsBe0eB/ngSCiwVZBp1GZG4CA7NhQ9+FiUYV
831oZjoRTMRtVCqMJZAPEHe++OAKb5FCy0gb1O7bfQjqn1HG9LfN+TbgiCb4CwMo
aabK2e+60NF+UpQ6r9j/HmMrDE3SOpxLyNoyj+/hR4DBuw+MQCqBY4B6f3xwHdTE
m9p1BgGdLEyAxHBhsDbeeAT+jCMHLC3inwZkiU1EWa5bO+6VABk6iQOH/yFHA/Ph
stuEtsY9koXiOxjciV9rx5CZRHzf54PcKkFbBGuZB52KkpwLrBBB1pIWE6ah/akt
eMS01TR+8L6wiJaZa3qtJH+PR35feGtzuRmWQLUzi898UWuEtGxaVJn/0dwefbkV
CKLSmMQLwzsrLCVZYO2zpUitEZkhOQzdSs5CEHyCiNtpuRABX4Zg5zEJuaHlsD+z
gXF4YGCrK1HGz79ekeBvYD1eQZLHw9BDWoi4xOxhrPYTHCpJkjVIs6t6TD2CyOk2
WdQrpgpyGwe4tg8zb0d0
=nw0M
-----END PGP SIGNATURE-----

--=-uxUCu/RNPok7omOLWy6A--