From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752089AbdH3RNt (ORCPT <rfc822;w@1wt.eu>);
        Wed, 30 Aug 2017 13:13:49 -0400
Received: from mout.gmx.net ([212.227.17.21]:53457 "EHLO mout.gmx.net"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751333AbdH3RNs (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 30 Aug 2017 13:13:48 -0400
Message-ID: <1504113212.5852.6.camel@gmx.de>
Subject: Re: tip -ENOBOOT - bisected to locking/refcounts, x86/asm:
 Implement fast refcount overflow protection
From: Mike Galbraith <efault@gmx.de>
To: Kees Cook <keescook@chromium.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
        "Reshetova, Elena" <elena.reshetova@intel.com>
Date: Wed, 30 Aug 2017 19:13:32 +0200
In-Reply-To: <CAGXu5jJim=r8b+y1qQXtuzm9fPyv1tp9ANebxbCc9ic2c83_Mg@mail.gmail.com>
References: <1503996623.8323.20.camel@gmx.de>
         <CAGXu5jLYHy6Damtg_Pc4=G76OUiMV3fcY9+Ru1-Lmiq6VWEgsw@mail.gmail.com>
         <1504025721.6024.25.camel@gmx.de> <1504030207.6560.0.camel@gmx.de>
         <CAGXu5jKSWiZ8NkgUqO6G8fs5R06bMtdFBmZz9MMX-HAk8nXXNw@mail.gmail.com>
         <1504069332.8352.3.camel@gmx.de>
         <CAGXu5jJim=r8b+y1qQXtuzm9fPyv1tp9ANebxbCc9ic2c83_Mg@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.20.5 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:t6512EzK6ikJmIdeT2XmpP2aGmNLW9ObTBP1HD/eeZfC2VkElV9
 ZlnFbc68Vi5RJG8n98RlFVlqgY3RD8QYTXhBLnJcIhjv0fwfZ0j1530JqDGWgkN681LwXuo
 /UeNhQT9hDt+qbYU7PLbMETMp976ko+bKI3Y2pqh+tSRPFQNoPBpKu/KO2vOFSIVaZMBFiV
 /8xctANjKyrFc+tW/6oMw==
X-UI-Out-Filterresults: notjunk:1;V01:K0:yg07YiB+v/U=:GCKLure40OuIPiz0YuMsg1
 D8aLIHCNUtzX6ple2InCI43PMrzmJVVWcH1TFkpZgwsgLLfSaM36PeSk+UK0tEbaTxS7Zw75M
 OVFRiWeofdGlF3HF18Tx52a98qw4RVgIHRbfusVRQ6qgSTtcVdvYGKHOqLLT55viGdov/+TeX
 u3M9KiE/ui9wxf24/bK3ma6njXJLYO7UUzAiSU+A5eP3EugA1DTQT4/7zi/GAoTtF4sBkfO5M
 OafA8vlCGARuCaLAcfIvq/FK8lSxDnSwWHfM/E8BYOIQlyYmjdr0lqZcd940rooPHvD8r78o0
 ufJnWDHnvI0ai3H944kPXg+8mDnXXbF8woRSndvHrcJAvpSG9UUoW4TutaZ4plw2hVjoiDPli
 ZYsL/Xu0bgYStqb65912FUovZVPG+QBVz7IDEH41K2cU+7gzFmpzMRZF5I+RyysSy4NnlvVok
 eD7ZHyCyPfUThDIHj91gEoNJxB/f2fTRzpQ9qS+Nu5orCBpL2OzoKNN3iTOhUMhteYolrqa/B
 QTtwNQDjrS4wmr+O/55tFmEHW+u0YliYYOQ2fDeRgcjy3cGeYu9CNj0A+r2YCWhoeltJHfkcx
 3l/qPoFYNOtushQ6IvAHYIMoWqZNURfAkDWGBJ8w0qmpBp/ePc8GD68VrpEs09uzxv36Pboum
 rPAHe9eOePVRjDm84Z/C54zJ29+K84bT7Vko4eHH33M5w0jywF0edimblcYWZckFEGtnPP+VM
 UIIk0pX0AhXCJljbd2TjvG0G06mWvBqehEryS9FABeyl13a4LGHAeg8Z02cbQN4aXprWBkh1C
 UngWfdVyCdUDOok/icenbIIdSk885hNsTJ4HVkWCgfbggegSRk=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 2017-08-30 at 09:35 -0700, Kees Cook wrote:
> On Tue, Aug 29, 2017 at 10:02 PM, Mike Galbraith <efault@gmx.de> wrote:
> > On Tue, 2017-08-29 at 11:41 -0700, Kees Cook wrote:
> >> Can you also test with 14afee4b6092 ("net: convert sock.sk_wmem_alloc
> >> from atomic_t to refcount_t") reverted (instead of ARCH_HAS_REFCOUNT
> >> disabled)?
> >
> > Nogo.
> 
> Thanks for checking!
> 
> > [   44.901930] WARNING: CPU: 5 PID: 0 at net/netlink/af_netlink.c:374 netlink_sock_destruct+0x82/0xa0
> 
> This is so odd if 14afee4b6092 is reverted. What is line 374 for you
> in net/netlink/af_netlink.c?

374         WARN_ON(atomic_read(&sk->sk_rmem_alloc));

That line is unchanged by 14afee4b6092.

	-Mike