mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: rui.zhang@intel.com, edubezval@gmail.com
Cc: daniel.lezcano@linaro.org, linux-pm@vger.kernel.org,
	kevin.wangtao@linaro.org, leo.yan@linaro.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH V2 01/13] thermal/drivers/hisi: Fix missing interrupt enablement
Date: Mon,  4 Sep 2017 21:56:00 +0200	[thread overview]
Message-ID: <1504554972-2624-1-git-send-email-daniel.lezcano@linaro.org> (raw)

The interrupt for the temperature threshold is not enabled at the end of the
probe function, enable it after the setup is complete.

On the other side, the irq_enabled is not correctly set as we are checking if
the interrupt is masked where 'yes' means irq_enabled=false.

	irq_get_irqchip_state(data->irq, IRQCHIP_STATE_MASKED,
				&data->irq_enabled);

As we are always enabling the interrupt, it is pointless to check if
the interrupt is masked or not, just set irq_enabled to 'true'.

Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Reviewed-by: Leo Yan <leo.yan@linaro.org>
Tested-by: Leo Yan <leo.yan@linaro.org>
---
 drivers/thermal/hisi_thermal.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/thermal/hisi_thermal.c b/drivers/thermal/hisi_thermal.c
index bd3572c..8381696 100644
--- a/drivers/thermal/hisi_thermal.c
+++ b/drivers/thermal/hisi_thermal.c
@@ -345,8 +345,7 @@ static int hisi_thermal_probe(struct platform_device *pdev)
 	}
 
 	hisi_thermal_enable_bind_irq_sensor(data);
-	irq_get_irqchip_state(data->irq, IRQCHIP_STATE_MASKED,
-			      &data->irq_enabled);
+	data->irq_enabled = true;
 
 	for (i = 0; i < HISI_MAX_SENSORS; ++i) {
 		ret = hisi_thermal_register_sensor(pdev, data,
@@ -358,6 +357,8 @@ static int hisi_thermal_probe(struct platform_device *pdev)
 			hisi_thermal_toggle_sensor(&data->sensors[i], true);
 	}
 
+	enable_irq(data->irq);
+
 	return 0;
 }
 
-- 
2.7.4

             reply	other threads:[~2017-09-04 19:57 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-04 19:56 Daniel Lezcano [this message]
2017-09-04 19:56 ` [PATCH V2 02/13] thermal/drivers/hisi: Remove the multiple sensors support Daniel Lezcano
2017-09-04 19:56 ` [PATCH V2 03/13] thermal/drivers/hisi: Fix kernel panic on alarm interrupt Daniel Lezcano
2017-09-04 19:56 ` [PATCH V2 04/13] thermal/drivers/hisi: Simplify the temperature/step computation Daniel Lezcano
2017-09-04 19:56 ` [PATCH V2 05/13] thermal/drivers/hisi: Fix multiple alarm interrupts firing Daniel Lezcano
2017-09-04 19:56 ` [PATCH V2 06/13] thermal/drivers/hisi: Remove pointless lock Daniel Lezcano
2017-09-08  3:16   ` Eduardo Valentin
2017-09-08  9:31     ` Daniel Lezcano
2017-09-04 19:56 ` [PATCH V2 07/13] thermal/drivers/hisi: Encapsulate register writes into helpers Daniel Lezcano
2017-09-04 19:56 ` [PATCH V2 08/13] thermal/drivers/hisi: Fix configuration register setting Daniel Lezcano
2017-09-04 19:56 ` [PATCH V2 09/13] thermal/drivers/hisi: Remove costly sensor inspection Daniel Lezcano
2017-09-08  3:22   ` Eduardo Valentin
2017-09-08  9:50     ` Daniel Lezcano
2017-09-04 19:56 ` [PATCH V2 10/13] thermal/drivers/hisi: Rename and remove unused field Daniel Lezcano
2017-09-04 19:56 ` [PATCH V2 11/13] thermal/drivers/hisi: Convert long to int Daniel Lezcano
2017-09-04 19:56 ` [PATCH V2 12/13] thermal/drivers/hisi: Remove thermal data back pointer Daniel Lezcano
2017-09-04 19:56 ` [PATCH V2 13/13] thermal/drivers/hisi: Remove mutex_lock in the code Daniel Lezcano
2017-09-08  3:25   ` Eduardo Valentin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1504554972-2624-1-git-send-email-daniel.lezcano@linaro.org \
    --to=daniel.lezcano@linaro.org \
    --cc=edubezval@gmail.com \
    --cc=kevin.wangtao@linaro.org \
    --cc=leo.yan@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome