From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755368AbdIFWeM (ORCPT ); Wed, 6 Sep 2017 18:34:12 -0400 Received: from mga04.intel.com ([192.55.52.120]:10324 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932603AbdIFWeH (ORCPT ); Wed, 6 Sep 2017 18:34:07 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,355,1500966000"; d="scan'208";a="148357546" From: "Bernat, Yehezkel" To: "dvhart@infradead.org" , "Mario.Limonciello@dell.com" CC: "mika.westerberg@linux.intel.com" , "linux-kernel@vger.kernel.org" , "platform-driver-x86@vger.kernel.org" , "hughsient@gmail.com" Subject: Re: Fwd: [PATCH] Add driver to force WMI Thunderbolt controller power status Thread-Topic: Fwd: [PATCH] Add driver to force WMI Thunderbolt controller power status Thread-Index: AQHTJ0YV8o1w6haZs0+qP3ceDgEFGaKoQZmAgAABehCAAAaUgIAABLSAgAAUfACAAA1DAIAAAdqA Date: Wed, 6 Sep 2017 22:34:02 +0000 Message-ID: <1504737247.2677.170.camel@intel.com> References: <1504720440-24423-1-git-send-email-mario.limonciello@dell.com> <1504726863.2677.154.camel@intel.com> <20170906200953.GA8298@fury> <1504729603.2677.167.camel@intel.com> <7edd73cbe3ba4d7b80a6614e93f4d538@ausx13mpc120.AMER.DELL.COM> <20170906222730.GB8298@fury> In-Reply-To: <20170906222730.GB8298@fury> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.18.5.2-0ubuntu3.2 authentication-results: spf=none (sender IP is ) smtp.mailfrom=yehezkel.bernat@intel.com; x-originating-ip: [134.191.232.68] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;BN4PR11MB0978;6:YPPlNw9ceAD6xGf7N/mXKcwSGS7aZQp+4iesDu3LlwffakKhFh19prpian0tIOeuwkgIZCRckQjtZIjPEsC3GhVSzyaq/5s4LV1Sd4W4k0Ikzp/lBBokimcf9DXZtleJQ4t3LKtwDHCxMMlkpSdYQubO9crTDr95DbugU0qiC00SSgnQdaminS1F6z9GdzxdQgwrXbp6Oj/I1mFezKDLjH7oxW91NIZQjU23WnhTPmk/B0m1vEOjxK64P9tv6up0GTGRH3mTm0V2bLm1whpV5e3SOb2ABTL6FA+TUwLyiwejG2TQhWq2JabFSBuzV1vwyMPJBb8H+IwF6fF0A79HxA==;5:4yf9n9q1VpZD+uBRFz+kyf7A6uCGrwXNTkC165DF9AwJ2nAwtlqUpSzL50TojEDvtmv4wdkmV3RF5Wug7Wp8LCl8gxip08lSLuQiPdOohQrnO7wsAFRAO0Y45OL9sXy2l8X9eoA75zjNH4fMIKQiZw==;24:r/l1sQIbuW2n3icfxisIwiWejv8WbgDEHY38J1tJ60ylg0UQcjlWiClXxDTSXLrlub+OZjRnkdvdVpINQcbfYy0Uu+6WO98QtHtxS99oops=;7:q81K60SzJtfoDEXZ7N2op4YoVrGskLBsWrQTIlU5F1vxFNKQHGEalYl8xFOblSY1B4Vtee+kEZiSJhEHtmlkAfRTlN80ytalyHjsQD8R2MA4xe9OC8ty5FoX1U04TEf8N1qEzLJVLHqgLJ3AdnHv/mPvnJder+dDqtiqPM+pn3EPg9M/LbAMY+hnFiz/6SRjIaoc1yMNFW8DsEmcJkAovVAbTmtfGAh9rCXlXEeeUos= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 056190b7-2fe3-40ca-5821-08d4f5776009 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(300000502095)(300135100095)(22001)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:BN4PR11MB0978; x-ms-traffictypediagnostic: BN4PR11MB0978: x-exchange-antispam-report-test: UriScan:(9452136761055)(56004941905204)(228905959029699); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(10201501046)(3002001)(93006095)(93001095)(6041248)(20161123558100)(20161123560025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:BN4PR11MB0978;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:BN4PR11MB0978; x-forefront-prvs: 0422860ED4 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39830400002)(377424004)(199003)(377454003)(13464003)(24454002)(189002)(53936002)(53546010)(2501003)(6506006)(3846002)(81166006)(102836003)(6116002)(305945005)(7736002)(93886005)(4326008)(2950100002)(25786009)(478600001)(5660300001)(3280700002)(97736004)(8676002)(8936002)(50226002)(86362001)(3660700001)(39060400002)(2900100001)(2906002)(81156014)(33646002)(66066001)(101416001)(36756003)(105586002)(103116003)(50986999)(6486002)(229853002)(14454004)(6512007)(68736007)(54906002)(8666007)(6246003)(189998001)(99286003)(77096006)(106356001)(76176999)(6436002)(99106002);DIR:OUT;SFP:1102;SCL:1;SRVR:BN4PR11MB0978;H:BN4PR11MB0996.namprd11.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <0E44F2152618A24E9CC5D0F8CE1408A6@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Sep 2017 22:34:02.5033 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN4PR11MB0978 X-OriginatorOrg: intel.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v86MYLt9003147 On Wed, 2017-09-06 at 15:27 -0700, Darren Hart wrote: > On Wed, Sep 06, 2017 at 09:40:02PM +0000, Mario.Limonciello@dell.com > wrote: > > > > > > > > -----Original Message----- > > > From: Bernat, Yehezkel [mailto:yehezkel.bernat@intel.com] > > > Sent: Wednesday, September 6, 2017 3:27 PM > > > To: dvhart@infradead.org; Limonciello, Mario > > ell.com> > > > Cc: mika.westerberg@linux.intel.com; linux-kernel@vger.kernel.org > > > ; platform- > > > driver-x86@vger.kernel.org; hughsient@gmail.com > > > Subject: Re: Fwd: [PATCH] Add driver to force WMI Thunderbolt > > > controller power > > > status > > > > > > On Wed, 2017-09-06 at 13:09 -0700, Darren Hart wrote: > > > > > > > > The other question I had about this was if the typical use case > > > > involves the OS, > > > > or if the firmware update (for example) would be performed as > > > > part of > > > > the > > > > general platform firmware update (from the UEFI update > > > > utility). > > > First, there is the use-case of add-in card, where it's > > > impossible to > > > use UEFI-based update, as much as I understand, as the BIOS isn't > > > expected to expose an ESRT entry for it. > > > > > > Even for built-in controller, my impression is that most OEMs use > > > a FW > > > update application (running on Windows) and are not publishing a > > > UEFI- > > > based solution. > > Yeah I'd agree with that impression. > > > > Even if an OEM does choose to publish a UEFI based solution, it's > > still > > useful to present FW information for the TBT controller in fwupd > > however too. > > > > Similar to how fwupd displays the information for the ME even > > though > > the ME is typically updated via UEFI. > So this raises the question: can we come up with a mechanism as part > of the tb > driver that will work on both on-board controllers and add on cards? > In it's > current form, this driver will only address on-board controllers. Both this wmi driver and Thunderbolt driver are relevant for both on- board controllers and add-in cards. Maybe I'm missing something. Would you mind to elaborate? > > The TB driver could use the WMI method if it exists, or some other > method to > power it up, but present the same sysfs interface to userspace... >