From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757232AbdIHWPo (ORCPT ); Fri, 8 Sep 2017 18:15:44 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:34048 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756895AbdIHWPn (ORCPT ); Fri, 8 Sep 2017 18:15:43 -0400 X-Google-Smtp-Source: ADKCNb7jzD60r+VmUfMhctTypq4r4qtHBp+vtwQvSulIF8Fl5CLlMKWGyTVLQ6Rx0zdP4imf0UiuOw== From: gurugio@gmail.com To: linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Gioh Kim , Gioh Kim Subject: [RFC] mm/memblock.c: using uninitialized value idx in memblock_add_range() Date: Sat, 9 Sep 2017 00:15:33 +0200 Message-Id: <1504908933-31667-1-git-send-email-gurugio@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Gioh Kim In memblock_add_range(), idx variable is a local value but I cannot find initialization of idx value. I checked idx value on my Qemu emulator. It was zero. Is there any hidden initialization code? Signed-off-by: Gioh Kim --- mm/memblock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/memblock.c b/mm/memblock.c index 7b8a5db..23374bc 100644 --- a/mm/memblock.c +++ b/mm/memblock.c @@ -515,7 +515,7 @@ int __init_memblock memblock_add_range(struct memblock_type *type, bool insert = false; phys_addr_t obase = base; phys_addr_t end = base + memblock_cap_size(base, &size); - int idx, nr_new; + int idx = 0, nr_new; struct memblock_region *rgn; if (!size) -- 2.7.4