From: kan.liang@intel.com
To: acme@kernel.org, peterz@infradead.org, mingo@redhat.com,
linux-kernel@vger.kernel.org
Cc: jolsa@kernel.org, namhyung@kernel.org, adrian.hunter@intel.com,
lukasz.odzioba@intel.com, ak@linux.intel.com,
Kan Liang <kan.liang@intel.com>
Subject: [PATCH RFC V2 04/10] petf tools: introduce a new function to set namespaces id
Date: Sun, 10 Sep 2017 19:23:17 -0700 [thread overview]
Message-ID: <1505096603-215017-5-git-send-email-kan.liang@intel.com> (raw)
In-Reply-To: <1505096603-215017-1-git-send-email-kan.liang@intel.com>
From: Kan Liang <kan.liang@intel.com>
Finish the namespaces id setting job in thread.c.
Signed-off-by: Kan Liang <kan.liang@intel.com>
---
tools/perf/util/hist.c | 7 ++-----
tools/perf/util/thread.c | 10 ++++++++++
tools/perf/util/thread.h | 2 ++
3 files changed, 14 insertions(+), 5 deletions(-)
diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c
index 0f00dd9..e332c4f 100644
--- a/tools/perf/util/hist.c
+++ b/tools/perf/util/hist.c
@@ -584,14 +584,9 @@ __hists__add_entry(struct hists *hists,
bool sample_self,
struct hist_entry_ops *ops)
{
- struct namespaces *ns = thread__namespaces(al->thread);
struct hist_entry entry = {
.thread = al->thread,
.comm_str = thread__comm_str(al->thread),
- .cgroup_id = {
- .dev = ns ? ns->link_info[CGROUP_NS_INDEX].dev : 0,
- .ino = ns ? ns->link_info[CGROUP_NS_INDEX].ino : 0,
- },
.ms = {
.map = al->map,
.sym = al->sym,
@@ -617,6 +612,8 @@ __hists__add_entry(struct hists *hists,
.ops = ops,
};
+ thread__namespaces_id(al->thread, &entry.cgroup_id.dev,
+ &entry.cgroup_id.ino);
return hists__findnew_entry(hists, &entry, al, sample_self);
}
diff --git a/tools/perf/util/thread.c b/tools/perf/util/thread.c
index aee9a42..b7957da 100644
--- a/tools/perf/util/thread.c
+++ b/tools/perf/util/thread.c
@@ -149,6 +149,16 @@ int thread__set_namespaces(struct thread *thread, u64 timestamp,
return 0;
}
+void thread__namespaces_id(const struct thread *thread,
+ u64 *dev, u64 *ino)
+{
+ struct namespaces *ns;
+
+ ns = thread__namespaces(thread);
+ *dev = ns ? ns->link_info[CGROUP_NS_INDEX].dev : 0;
+ *ino = ns ? ns->link_info[CGROUP_NS_INDEX].ino : 0;
+}
+
struct comm *thread__comm(const struct thread *thread)
{
if (list_empty(&thread->comm_list))
diff --git a/tools/perf/util/thread.h b/tools/perf/util/thread.h
index cb1a5dd..fd7bd41 100644
--- a/tools/perf/util/thread.h
+++ b/tools/perf/util/thread.h
@@ -68,6 +68,8 @@ static inline void thread__exited(struct thread *thread)
struct namespaces *thread__namespaces(const struct thread *thread);
int thread__set_namespaces(struct thread *thread, u64 timestamp,
struct namespaces_event *event);
+void thread__namespaces_id(const struct thread *thread,
+ u64 *dev, u64 *ino);
int __thread__set_comm(struct thread *thread, const char *comm, u64 timestamp,
bool exec);
--
2.5.5
next prev parent reply other threads:[~2017-09-11 2:25 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-11 2:23 [PATCH RFC V2 00/10] perf top optimization kan.liang
2017-09-11 2:23 ` [PATCH RFC V2 01/10] perf tools: hashtable for machine threads kan.liang
2017-09-13 13:29 ` Arnaldo Carvalho de Melo
2017-09-22 16:42 ` [tip:perf/core] perf machine: Use " tip-bot for Kan Liang
2017-09-11 2:23 ` [PATCH RFC V2 02/10] perf tools: using scandir to replace readdir kan.liang
2017-09-13 15:19 ` Arnaldo Carvalho de Melo
2017-09-11 2:23 ` [PATCH RFC V2 03/10] petf tools: using comm_str to replace comm in hist_entry kan.liang
2017-09-13 15:21 ` Arnaldo Carvalho de Melo
2017-09-18 8:38 ` Jiri Olsa
2017-09-11 2:23 ` kan.liang [this message]
2017-09-11 2:23 ` [PATCH RFC V2 05/10] perf tools: lock to protect thread list kan.liang
2017-09-18 8:50 ` Jiri Olsa
2017-09-18 16:18 ` Liang, Kan
2017-09-11 2:23 ` [PATCH RFC V2 06/10] perf tools: lock to protect comm_str rb tree kan.liang
2017-09-11 2:23 ` [PATCH RFC V2 07/10] perf tools: change machine comm_exec type to atomic kan.liang
2017-09-13 15:24 ` Arnaldo Carvalho de Melo
2017-09-15 20:05 ` Liang, Kan
2017-09-18 11:30 ` Jiri Olsa
2017-09-11 2:23 ` [PATCH RFC V2 08/10] perf top: implement multithreading for perf_event__synthesize_threads kan.liang
2017-09-18 11:24 ` Jiri Olsa
2017-09-11 2:23 ` [PATCH RFC V2 09/10] perf top: add option to set the number of thread for event synthesize kan.liang
2017-09-11 2:23 ` [PATCH RFC V2 10/10] perf top: switch back to overwrite mode kan.liang
2017-09-13 15:25 ` [PATCH RFC V2 00/10] perf top optimization Arnaldo Carvalho de Melo
2017-09-13 15:29 ` Liang, Kan
2017-09-13 15:38 ` Arnaldo Carvalho de Melo
2017-09-14 21:19 ` Arnaldo Carvalho de Melo
2017-09-15 15:11 ` Liang, Kan
2017-09-15 17:26 ` Arnaldo Carvalho de Melo
2017-09-15 17:29 ` Liang, Kan
2017-09-15 18:24 ` Arnaldo Carvalho de Melo
2017-09-15 18:26 ` Liang, Kan
2017-09-18 8:57 ` Jiri Olsa
2017-09-18 13:01 ` Arnaldo Carvalho de Melo
2017-09-18 16:21 ` Liang, Kan
2017-09-19 8:19 ` Jiri Olsa
2017-09-19 12:39 ` Liang, Kan
2017-09-19 14:24 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1505096603-215017-5-git-send-email-kan.liang@intel.com \
--to=kan.liang@intel.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukasz.odzioba@intel.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome