mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bo Yan <byan@nvidia.com>
To: <rostedt@goodmis.org>, <mingo@redhat.com>,
	<linux-kernel@vger.kernel.org>
Cc: Bo Yan <byan@nvidia.com>
Subject: [PATCH] tracing: erase irqsoff trace with empty write
Date: Mon, 11 Sep 2017 11:16:35 -0700	[thread overview]
Message-ID: <1505153795-12484-1-git-send-email-byan@nvidia.com> (raw)

One convenient way to erase trace is "echo > trace". However, this
is currently broken if the current tracer is irqsoff tracer. This
is because irqsoff tracer use max_buffer as the default trace
buffer.

Set the max_buffer as the one to be cleared when it's the trace
buffer currently in use.

Signed-off-by: Bo Yan <byan@nvidia.com>
---
 kernel/trace/trace.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index 5360b7aec57a..1f91bdd9365b 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -4020,11 +4020,17 @@ static int tracing_open(struct inode *inode, struct file *file)
 	/* If this file was open for write, then erase contents */
 	if ((file->f_mode & FMODE_WRITE) && (file->f_flags & O_TRUNC)) {
 		int cpu = tracing_get_cpu(inode);
+		struct trace_buffer *tr_buf = &tr->trace_buffer;
+
+#ifdef CONFIG_TRACER_MAX_TRACE
+		if (tr->current_trace->print_max)
+			tr_buf = &tr->max_buffer;
+#endif
 
 		if (cpu == RING_BUFFER_ALL_CPUS)
-			tracing_reset_online_cpus(&tr->trace_buffer);
+			tracing_reset_online_cpus(tr_buf);
 		else
-			tracing_reset(&tr->trace_buffer, cpu);
+			tracing_reset(tr_buf, cpu);
 	}
 
 	if (file->f_mode & FMODE_READ) {
-- 
2.7.4

             reply	other threads:[~2017-09-11 18:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-11 18:16 Bo Yan [this message]
2017-09-18 14:38 ` Steven Rostedt
2017-09-19 17:41   ` Bo Yan
2017-09-19 17:46     ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1505153795-12484-1-git-send-email-byan@nvidia.com \
    --to=byan@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®