From: Gerd Hoffmann <kraxel@redhat.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Emil Velikov <emil.l.velikov@gmail.com>
Cc: Colin King <colin.king@canonical.com>,
Dave Airlie <airlied@redhat.com>, David Airlie <airlied@linux.ie>,
"open list:VIRTIO GPU DRIVER"
<virtualization@lists.linux-foundation.org>,
ML dri-devel <dri-devel@lists.freedesktop.org>,
kernel-janitors@vger.kernel.org,
"Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm: qxl: ratelimit pr_info message, reduce log spamming
Date: Tue, 12 Sep 2017 16:21:57 +0200 [thread overview]
Message-ID: <1505226117.31639.24.camel@redhat.com> (raw)
In-Reply-To: <20170912140921.maegwq32x5a6jyql@mwanda>
On Tue, 2017-09-12 at 17:09 +0300, Dan Carpenter wrote:
> On Tue, Sep 12, 2017 at 03:02:04PM +0100, Emil Velikov wrote:
> > That said, I'm not sure how useful the information is - perhaps
> > it's
> > better to drop it all together?
>
> Or a WARN_ONCE().
It's userspace calling into the driver with invalid parameters.
IMO we should never WARN_ONCE() on something userspace can trigger.
I'd suggest to just drop the message altogether, simply throwing EINVAL
at userspace is perfectly fine IMHO.
cheers,
Gerd
prev parent reply other threads:[~2017-09-12 14:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-12 9:45 Colin King
2017-09-12 14:02 ` Emil Velikov
2017-09-12 14:09 ` Dan Carpenter
2017-09-12 14:21 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1505226117.31639.24.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=colin.king@canonical.com \
--cc=dan.carpenter@oracle.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®