From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751483AbdIORJr (ORCPT ); Fri, 15 Sep 2017 13:09:47 -0400 Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]:53138 "EHLO shadbolt.e.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750838AbdIORJq (ORCPT ); Fri, 15 Sep 2017 13:09:46 -0400 Message-ID: <1505495372.2825.39.camel@decadent.org.uk> Subject: Re: [PATCH 3.16 153/233] HID: usbhid: add quirk for innomedia INNEX GENESIS/ATARI adapter From: Ben Hutchings To: Tomasz Kramkowski Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, akpm@linux-foundation.org, Jiri Kosina , Benjamin Tissoires , Valtteri =?ISO-8859-1?Q?Heikkil=E4?= Date: Fri, 15 Sep 2017 18:09:32 +0100 In-Reply-To: <20170910113356.GA22849@gaia.local> References: <20170910113356.GA22849@gaia.local> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-h5F9y3WP/SWH9gig8AQ9" X-Mailer: Evolution 3.24.5-3 Mime-Version: 1.0 X-SA-Exim-Connect-IP: 82.70.136.246 X-SA-Exim-Mail-From: ben@decadent.org.uk X-SA-Exim-Scanned: No (on shadbolt.decadent.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-h5F9y3WP/SWH9gig8AQ9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, 2017-09-10 at 12:33 +0100, Tomasz Kramkowski wrote: > On Sat, Sep 09, 2017 at 10:47:14PM +0100, Ben Hutchings wrote: > > 3.16.48-rc1 review patch. If anyone has any objections, please let me = know. > >=20 > > ------------------ > >=20 > > From: Tomasz Kramkowski > >=20 > > commit 9547837bdccb4af127528b36a73377150658b4ac upstream. > >=20 > > The (1292:4745) Innomedia INNEX GENESIS/ATARI adapter needs > > HID_QUIRK_MULTI_INPUT to split the device up into two controllers > > instead of inputs from both being merged into one. > >=20 > > Signed-off-by: Tomasz Kramkowski > > Acked-By: Benjamin Tissoires > > Signed-off-by: Jiri Kosina > > [bwh: Backported to 3.16: adjust context] > > Signed-off-by: Ben Hutchings > > ---- snip ---- >=20 > Hi, >=20 > Unfortunately this quirk will not make the device mentioned in the commit > work on its own. >=20 > This fix was an additional fix on top of another more fundamental fix > which made the device, and others like it, operational. OK, I'm dropping this now and will consider adding the complete set of fixes in a later update. Perhaps you could send this list as a new message to stable@vger.kernel.org if you're interested in adding support for this device to stable branches. Ben. > This fix was included in commit: >=20 > Valtteri Heikkil=C3=A4 (1): > HID: reject input outside logical range only if null state is set > [3f3752705dbd50b66b66ad7b4d54fe33d2f746ed] >=20 > This patch does not appear in your shortlog for this submission and it > doesn't appear when I search linux-stable as of v3.16.47. >=20 > Additionally, the following patch might also be helpful in ensuring > the correct operation of the aforementioned device (and other devices > like it): >=20 > Tomasz Kramkowski (1): > HID: clamp input to logical range if no null state > [c3883fe06488a483658ba5d849b70e49bee15e7c] >=20 > However, if the above patches are not appropriate for backporting > to stable then I have absolutely nothing against my patch not being > backported either. My patch alone will not make the device operate in > a useful manner. >=20 > Thank you for considering my patch for the 3.16 stable tree and have a > nice day, >=20 --=20 Ben Hutchings Kids! Bringing about Armageddon can be dangerous. Do not attempt it in your own home. - Terry Pratchett and Neil Gaiman, `Good Omens' --=-h5F9y3WP/SWH9gig8AQ9 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEErCspvTSmr92z9o8157/I7JWGEQkFAlm8CUwACgkQ57/I7JWG EQkYKhAAnNdYBVOogsCX6EZ7KGrv+kKLad4YtRz1eBCvkeR6iNMhfZ8xrK9xE3k3 r3oOUqDIDVSGQ2rHofgtwM060k7Ip0O0Bmm5SR18hAlELfqi3INZ0jVdqV2AZuZv qcpK/Ksrtk+tyWcAubMdOynsUYjaD5TjIfcXnXjGv9jiJL8ZAjZoTJLqrzAwY+/O mEvf5ZYztjLD77VvfvRUa6P8+Wd+Br3DGIAD3j9mG18fkvruVJwNgnIYxdQZAqZG 0nQyNdx8yBAz5LHknUqsF8ycwgG1CPT/hdMvmkqr/vya306TtzWtcV0doG2RVdPx wlM71U96QBqQUmSyW34oAlnSwy7bFFr2QquarcgF92p4M0+Ea7/qeCGhrpNm/S6M l/ePH7VFyx0mkJ+qR3j4Nxc2TmsD02nxhG9VuWroG5wfKsA/P8OapPj5/+z3RwXR +iu+M8OFwpXSEmJobw61N0F3jbrlgsqdO9tkvMWfKCfXomErThzqH25VCFPqmRg5 Q5y+6kP8yDAVTb5a0s0WrBM2jWIA/KMttE1pjJUIG9mnkbDy72BqNDmNmjX9AvSc gedgR4z8Qnqj72QTEku1M7EUyInRPULDSUyAsPrZG8v+tCA+6Tw0fn4qU+wmgyt0 BFlWnnotp9ycfsSX/ram5BHGZ8GYy/qDdDIfOj4cHqK92n9Qdzk= =6oHb -----END PGP SIGNATURE----- --=-h5F9y3WP/SWH9gig8AQ9--