From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751342AbdIPTd5 (ORCPT ); Sat, 16 Sep 2017 15:33:57 -0400 Received: from smtprelay0189.hostedemail.com ([216.40.44.189]:45414 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751272AbdIPTd4 (ORCPT ); Sat, 16 Sep 2017 15:33:56 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::,RULES_HIT:41:334:355:368:369:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3867:3868:3870:3871:3872:4321:5007:6119:7576:10004:10400:10848:11026:11232:11473:11658:11914:12043:12048:12438:12740:12760:12895:13069:13311:13357:13439:14181:14659:14721:21080:21627:30054:30089:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: heat76_3f24a42a44b36 X-Filterd-Recvd-Size: 1734 Message-ID: <1505590431.16316.9.camel@perches.com> Subject: Re: [PATCH] i2c: i2c-stm32f7: make structure stm32f7_setup static From: Joe Perches To: Colin King , Wolfram Sang , Maxime Coquelin , Alexandre Torgue , linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Date: Sat, 16 Sep 2017 12:33:51 -0700 In-Reply-To: <20170916113308.25534-1-colin.king@canonical.com> References: <20170916113308.25534-1-colin.king@canonical.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2017-09-16 at 12:33 +0100, Colin King wrote: > From: Colin Ian King > > The structure stm32f7_setup is local to the source and does not need > to be in global scope, so make it static. > > Cleans up sparse warning: > symbol 'stm32f7_setup' was not declared. Should it be static? [] > diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c [] > @@ -265,7 +265,7 @@ static struct stm32f7_i2c_spec i2c_specs[] = { > }, > }; > > -struct stm32f7_i2c_setup stm32f7_setup = { > +static struct stm32f7_i2c_setup stm32f7_setup = { better to use static const > .rise_time = STM32F7_I2C_RISE_TIME_DEFAULT, > .fall_time = STM32F7_I2C_FALL_TIME_DEFAULT, > .dnf = STM32F7_I2C_DNF_DEFAULT,