From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751361AbdIQMOr (ORCPT ); Sun, 17 Sep 2017 08:14:47 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:33908 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750803AbdIQMOp (ORCPT ); Sun, 17 Sep 2017 08:14:45 -0400 X-Google-Smtp-Source: AOwi7QBk6Om6IUruu1SiInBPHwXArnVgfapOSgT8vnrNwIFCwJfeOnfPU+t6WW8JMHsxs2cjFei8SA== From: Sudip Mukherjee To: Ohad Ben-Cohen , Bjorn Andersson Cc: linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org, Sudip Mukherjee Subject: [PATCH] rpmsg: glink: fix memory leak Date: Sun, 17 Sep 2017 13:14:38 +0100 Message-Id: <1505650478-4638-1-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We missed freeing intent and intent->data on error conditions. Signed-off-by: Sudip Mukherjee --- drivers/rpmsg/qcom_glink_native.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/rpmsg/qcom_glink_native.c b/drivers/rpmsg/qcom_glink_native.c index 5a5e927..2e64c4d 100644 --- a/drivers/rpmsg/qcom_glink_native.c +++ b/drivers/rpmsg/qcom_glink_native.c @@ -640,13 +640,17 @@ qcom_glink_alloc_intent(struct qcom_glink *glink, return NULL; intent->data = kzalloc(size, GFP_KERNEL); - if (!intent->data) + if (!intent->data) { + kfree(intent); return NULL; + } spin_lock_irqsave(&channel->intent_lock, flags); ret = idr_alloc_cyclic(&channel->liids, intent, 1, -1, GFP_ATOMIC); if (ret < 0) { spin_unlock_irqrestore(&channel->intent_lock, flags); + kfree(intent->data); + kfree(intent); return NULL; } spin_unlock_irqrestore(&channel->intent_lock, flags); -- 2.7.4