From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751377AbdIREUU (ORCPT ); Mon, 18 Sep 2017 00:20:20 -0400 Received: from smtpbguseast2.qq.com ([54.204.34.130]:59994 "EHLO smtpbguseast2.qq.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751086AbdIREUS (ORCPT ); Mon, 18 Sep 2017 00:20:18 -0400 X-QQ-mid: bizesmtp5t1505708409t1rw154m9 X-QQ-SSF: 01100000008000F0FNF0B00A0000000 X-QQ-FEAT: Ngtn/3KK5ep4ev+iGM8EcxYtMA4YNSaUIzdcxLAnTP9hdE7Lmyznf+zK3SYXL 7BylRyxaV/C5sNo8PzEU+0Cc7qvIeXDfQ4FDgMotbOeUe5yO88JYXHavEx1M5kZbkm4qDoN J3Ud5T0oSFDaOgogDj2vqghlCryreYqQboq4o1GCRNxG+FpSSZO6xB899VAdavDO2FcEyK7 q6VohCRFoUQTvKE4nwZfiXm+z3vRczektcbQFm55jOPtsyCoHCE2u1+9U7BWUZ/PKAsMnAn HaOaeuBqIviDuBIWh6lMDGfl1LdcHXDRODIvHwEb/mlZs9 X-QQ-GoodBg: 0 From: Huacai Chen To: Christoph Hellwig Cc: Marek Szyprowski , Robin Murphy , Andrew Morton , Fuxin Zhang , linux-kernel@vger.kernel.org, Huacai Chen , stable@vger.kernel.org Subject: [PATCH V5 1/3] dma-mapping: Introduce device_is_coherent() as a helper Date: Mon, 18 Sep 2017 12:21:40 +0800 Message-Id: <1505708500-3743-1-git-send-email-chenhc@lemote.com> X-Mailer: git-send-email 2.7.0 X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:lemote.com:qybgforeign:qybgforeign1 X-QQ-Bgrelay: 1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We will use device_is_coherent() as a helper function, in order to set an appropriate dma alignment in dmapool and block queue (other patches in this series). There is a MIPS-specific plat_device_is_coherent(), but we need a more generic solution, so add and use a new function pointer in dma_map_ops. Cc: stable@vger.kernel.org Signed-off-by: Huacai Chen --- arch/mips/cavium-octeon/dma-octeon.c | 3 ++- arch/mips/loongson64/common/dma-swiotlb.c | 1 + arch/mips/mm/dma-default.c | 3 ++- arch/mips/netlogic/common/nlm-dma.c | 3 ++- include/linux/dma-mapping.h | 10 ++++++++++ 5 files changed, 17 insertions(+), 3 deletions(-) diff --git a/arch/mips/cavium-octeon/dma-octeon.c b/arch/mips/cavium-octeon/dma-octeon.c index c64bd87..cd1a133 100644 --- a/arch/mips/cavium-octeon/dma-octeon.c +++ b/arch/mips/cavium-octeon/dma-octeon.c @@ -324,7 +324,8 @@ static struct octeon_dma_map_ops _octeon_pci_dma_map_ops = { .sync_sg_for_cpu = swiotlb_sync_sg_for_cpu, .sync_sg_for_device = octeon_dma_sync_sg_for_device, .mapping_error = swiotlb_dma_mapping_error, - .dma_supported = swiotlb_dma_supported + .dma_supported = swiotlb_dma_supported, + .device_is_coherent = plat_device_is_coherent }, }; diff --git a/arch/mips/loongson64/common/dma-swiotlb.c b/arch/mips/loongson64/common/dma-swiotlb.c index 34486c1..c758d9b 100644 --- a/arch/mips/loongson64/common/dma-swiotlb.c +++ b/arch/mips/loongson64/common/dma-swiotlb.c @@ -119,6 +119,7 @@ static const struct dma_map_ops loongson_dma_map_ops = { .sync_sg_for_device = loongson_dma_sync_sg_for_device, .mapping_error = swiotlb_dma_mapping_error, .dma_supported = loongson_dma_supported, + .device_is_coherent = plat_device_is_coherent }; void __init plat_swiotlb_setup(void) diff --git a/arch/mips/mm/dma-default.c b/arch/mips/mm/dma-default.c index c01bd20..6e18301 100644 --- a/arch/mips/mm/dma-default.c +++ b/arch/mips/mm/dma-default.c @@ -407,7 +407,8 @@ static const struct dma_map_ops mips_default_dma_map_ops = { .sync_sg_for_cpu = mips_dma_sync_sg_for_cpu, .sync_sg_for_device = mips_dma_sync_sg_for_device, .mapping_error = mips_dma_mapping_error, - .dma_supported = mips_dma_supported + .dma_supported = mips_dma_supported, + .device_is_coherent = plat_device_is_coherent }; const struct dma_map_ops *mips_dma_map_ops = &mips_default_dma_map_ops; diff --git a/arch/mips/netlogic/common/nlm-dma.c b/arch/mips/netlogic/common/nlm-dma.c index 0ec9d9d..aa11b27 100644 --- a/arch/mips/netlogic/common/nlm-dma.c +++ b/arch/mips/netlogic/common/nlm-dma.c @@ -79,7 +79,8 @@ const struct dma_map_ops nlm_swiotlb_dma_ops = { .sync_sg_for_cpu = swiotlb_sync_sg_for_cpu, .sync_sg_for_device = swiotlb_sync_sg_for_device, .mapping_error = swiotlb_dma_mapping_error, - .dma_supported = swiotlb_dma_supported + .dma_supported = swiotlb_dma_supported, + .device_is_coherent = plat_device_is_coherent }; void __init plat_swiotlb_setup(void) diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h index 29ce981..08da227 100644 --- a/include/linux/dma-mapping.h +++ b/include/linux/dma-mapping.h @@ -131,6 +131,7 @@ struct dma_map_ops { #ifdef ARCH_HAS_DMA_GET_REQUIRED_MASK u64 (*get_required_mask)(struct device *dev); #endif + int (*device_is_coherent)(struct device *dev); int is_phys; }; @@ -697,6 +698,15 @@ static inline void *dma_zalloc_coherent(struct device *dev, size_t size, } #ifdef CONFIG_HAS_DMA +static inline int device_is_coherent(struct device *dev) +{ + const struct dma_map_ops *ops = get_dma_ops(dev); + if (ops && ops->device_is_coherent) + return ops->device_is_coherent(dev); + else + return 1; /* compatible behavior */ +} + static inline int dma_get_cache_alignment(void) { #ifdef ARCH_DMA_MINALIGN -- 2.7.0