From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751691AbdISPuu (ORCPT ); Tue, 19 Sep 2017 11:50:50 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:52321 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751283AbdISPut (ORCPT ); Tue, 19 Sep 2017 11:50:49 -0400 X-ME-Sender: Message-Id: <1505836248.392159.1111298816.4DE9BCE7@webmail.messagingengine.com> From: Tobin Harding To: Greg KH , Stephen Rothwell Cc: "Linux-Next Mailing List" , Linux Kernel Mailing List MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" X-Mailer: MessagingEngine.com Webmail Interface - ajax-64b08692 References: <20170919075455.59a3183b@canb.auug.org.au> <20170919060915.GA1628@kroah.com> <1505835299.387461.1111276008.64AD9525@webmail.messagingengine.com> Subject: Re: linux-next: Signed-off-by missing for commits in the staging tree In-Reply-To: <1505835299.387461.1111276008.64AD9525@webmail.messagingengine.com> Date: Wed, 20 Sep 2017 01:50:48 +1000 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 20, 2017, at 01:34, Tobin Harding wrote: > > On Tue, Sep 19, 2017, at 16:09, Greg KH wrote: > > On Tue, Sep 19, 2017 at 07:54:55AM +1000, Stephen Rothwell wrote: > > > Hi Greg, > > > > > > Commits > > > > > > 688a0206cfb8 ("staging: rtlwifi: fix parenthesis alignment") > > > 85d309d53f7a ("staging: rtlwifi: use kcalloc instead of multiply") > > > f216f6cdeb1d ("staging: rtlwifi: remove unused functions") > > > > > > are missing a Signed-off-by from their author. > > > > Ugh, I totally missed that, Tobin, what went wrong here? > > Apologies, I bet I didn't set up my environment on the laptop fully. > Usual dev machine is a desktop, I did these patches as prep for OSS. I've got a strong feeling I didn't enable the driver before I 'built' this patch series also. Bad Tobin. Luckily the kbot didn't punish me.