From: Chanwoo Choi <cw00.choi@samsung.com>
To: myungjoo.ham@samsung.com, kyungmin.park@samsung.com,
cw00.choi@samsung.com
Cc: rafael.j.wysocki@intel.com, chanwoo@kernel.org,
inki.dae@samsung.com, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 1/8] PM / devfreq: Set min/max_freq when adding the devfreq device
Date: Thu, 21 Sep 2017 09:33:45 +0900 [thread overview]
Message-ID: <1505954032-3327-2-git-send-email-cw00.choi@samsung.com> (raw)
In-Reply-To: <1505954032-3327-1-git-send-email-cw00.choi@samsung.com>
Prior to that, the min/max_freq of the devfreq device are always zero
before the user changes the min/max_freq through sysfs entries.
It might make the confusion for the min/max_freq.
This patch initializes the available min/max_freq by using the OPP
during adding the devfreq device.
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
---
drivers/devfreq/devfreq.c | 43 +++++++++++++++++++++++++++++++++++++++++++
1 file changed, 43 insertions(+)
diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
index a1c4ee818614..ae8717a6eee1 100644
--- a/drivers/devfreq/devfreq.c
+++ b/drivers/devfreq/devfreq.c
@@ -69,6 +69,34 @@ static struct devfreq *find_device_devfreq(struct device *dev)
return ERR_PTR(-ENODEV);
}
+static unsigned long find_available_min_freq(struct devfreq *devfreq)
+{
+ struct dev_pm_opp *opp;
+ unsigned long min_freq = 0;
+
+ opp = dev_pm_opp_find_freq_ceil(devfreq->dev.parent, &min_freq);
+ if (IS_ERR(opp))
+ min_freq = 0;
+ else
+ dev_pm_opp_put(opp);
+
+ return min_freq;
+}
+
+static unsigned long find_available_max_freq(struct devfreq *devfreq)
+{
+ struct dev_pm_opp *opp;
+ unsigned long max_freq = ULONG_MAX;
+
+ opp = dev_pm_opp_find_freq_floor(devfreq->dev.parent, &max_freq);
+ if (IS_ERR(opp))
+ max_freq = 0;
+ else
+ dev_pm_opp_put(opp);
+
+ return max_freq;
+}
+
/**
* devfreq_get_freq_level() - Lookup freq_table for the frequency
* @devfreq: the devfreq instance
@@ -559,6 +587,21 @@ struct devfreq *devfreq_add_device(struct device *dev,
mutex_lock(&devfreq->lock);
}
+ /* Set the scaling available min_freq and max_freq */
+ devfreq->min_freq = find_available_min_freq(devfreq);
+ if (!devfreq->min_freq) {
+ mutex_unlock(&devfreq->lock);
+ err = -EINVAL;
+ goto err_dev;
+ }
+
+ devfreq->max_freq = find_available_max_freq(devfreq);
+ if (!devfreq->max_freq) {
+ mutex_unlock(&devfreq->lock);
+ err = -EINVAL;
+ goto err_dev;
+ }
+
dev_set_name(&devfreq->dev, "devfreq%d",
atomic_inc_return(&devfreq_no));
err = device_register(&devfreq->dev);
--
1.9.1
next prev parent reply other threads:[~2017-09-21 0:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170921003355epcas1p1d1bbb04ff7a7c46946f62a91883bd6a6@epcas1p1.samsung.com>
2017-09-21 0:33 ` [PATCH v2 0/8] PM / devfreq: Use OPP interface to handle the frequency Chanwoo Choi
[not found] ` <CGME20170921003355epcas1p42e0547938d45c32c3064895140bf5848@epcas1p4.samsung.com>
2017-09-21 0:33 ` Chanwoo Choi [this message]
[not found] ` <CGME20170921003355epcas1p4ecc54d2b7437b4e0d052d9b99647930e@epcas1p4.samsung.com>
2017-09-21 0:33 ` [PATCH v2 2/8] Revert "PM / devfreq: Add show_one macro to delete the duplicate code" Chanwoo Choi
[not found] ` <CGME20170921003355epcas1p24e2126b498dedf4c1112bac783de187b@epcas1p2.samsung.com>
2017-09-21 0:33 ` [PATCH v2 3/8] PM / devfreq: Show the available min/max frequency through sysfs node Chanwoo Choi
[not found] ` <CGME20170921003356epcas1p4c6e4da1fab6f56468ecca9e5889faa43@epcas1p4.samsung.com>
2017-09-21 0:33 ` [PATCH v2 4/8] PM / devfreq: Show the all available frequencies Chanwoo Choi
[not found] ` <CGME20170921003356epcas1p3de34905f87bca5760f80d196a004e1a0@epcas1p3.samsung.com>
2017-09-21 0:33 ` [PATCH v2 5/8] PM / devfreq: Get the available next frequency on update_devfreq() Chanwoo Choi
[not found] ` <CGME20170921003356epcas1p246204a12c12e4c9ed94771dc25ce143d@epcas1p2.samsung.com>
2017-09-21 0:33 ` [PATCH v2 6/8] PM / devfreq: Remove unneeded conditional statement Chanwoo Choi
[not found] ` <CGME20170921003356epcas1p20d38fddcbcf1534de97af75345927f7a@epcas1p2.samsung.com>
2017-09-21 0:33 ` [PATCH v2 7/8] PM / devfreq: Define the constant governor name Chanwoo Choi
[not found] ` <CGME20170921003356epcas1p34bf88ccd1b9630577a83f14f0c291b1d@epcas1p3.samsung.com>
2017-09-21 0:33 ` [PATCH v2 8/8] PM / devfreq: exynos-bus: Register cooling device Chanwoo Choi
2017-09-21 4:57 ` Chanwoo Choi
[not found] ` <CGME20170926023151epcas1p41f999f2804facb4548b2d42ac3a00601@epcas1p4.samsung.com>
2017-09-26 2:31 ` [PATCH v2.1] " Chanwoo Choi
2017-09-27 1:28 ` [PATCH v2 0/8] PM / devfreq: Use OPP interface to handle the frequency Chanwoo Choi
[not found] ` <CGME20170921003355epcas1p1d1bbb04ff7a7c46946f62a91883bd6a6@epcms1p3>
2017-09-27 8:09 ` MyungJoo Ham
2017-09-27 8:15 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1505954032-3327-2-git-send-email-cw00.choi@samsung.com \
--to=cw00.choi@samsung.com \
--cc=chanwoo@kernel.org \
--cc=inki.dae@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®