From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752000AbdIULYe (ORCPT ); Thu, 21 Sep 2017 07:24:34 -0400 Received: from mail-pg0-f65.google.com ([74.125.83.65]:33082 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751908AbdIULYb (ORCPT ); Thu, 21 Sep 2017 07:24:31 -0400 X-Google-Smtp-Source: AOwi7QAwLDcQ7xACvC9vX9pAwl8tXV/TsSACnNQR/gNgzM2iyIVz2Bed4LwFyk0bYaovebN7Xx6Rpg== From: Allen Pais To: linux-kernel@vger.kernel.org Cc: johan@kernel.org, gregkh@linuxfoundation.org, Allen Pais Subject: [PATCH 1/1] driver:garmin gps: use setup_timer Date: Thu, 21 Sep 2017 16:54:24 +0530 Message-Id: <1505993064-30745-1-git-send-email-allen.lkml@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use setup_timer function instead of initializing timer with the function and data fields. Signed-off-by: Allen Pais --- drivers/usb/serial/garmin_gps.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/usb/serial/garmin_gps.c b/drivers/usb/serial/garmin_gps.c index b2f2e87..2dbc1bed 100644 --- a/drivers/usb/serial/garmin_gps.c +++ b/drivers/usb/serial/garmin_gps.c @@ -1391,12 +1391,11 @@ static int garmin_port_probe(struct usb_serial_port *port) if (!garmin_data_p) return -ENOMEM; - init_timer(&garmin_data_p->timer); + setup_timer(&garmin_data_p->timer, timeout_handler, + (unsigned long)garmin_data_p); spin_lock_init(&garmin_data_p->lock); INIT_LIST_HEAD(&garmin_data_p->pktlist); /* garmin_data_p->timer.expires = jiffies + session_timeout; */ - garmin_data_p->timer.data = (unsigned long)garmin_data_p; - garmin_data_p->timer.function = timeout_handler; garmin_data_p->port = port; garmin_data_p->state = 0; garmin_data_p->flags = 0; -- 2.7.4