From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751806AbdIUMsE (ORCPT ); Thu, 21 Sep 2017 08:48:04 -0400 Received: from mail-pg0-f67.google.com ([74.125.83.67]:37806 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751531AbdIUMsC (ORCPT ); Thu, 21 Sep 2017 08:48:02 -0400 X-Google-Smtp-Source: AOwi7QAX+2+HLH5G18LEbkhSF5LUko4wrYHDEeV88rfXIgrB3a2yvkgkp9NDmz03IzKPgCNgE0NM9Q== From: Allen Pais To: linux-kernel@vger.kernel.org Cc: khc@pm.waw.pl, netdev@vger.kernel.org, Allen Pais Subject: [PATCH 1/1] net: wan : hdlc: use setup_timer() helper Date: Thu, 21 Sep 2017 18:17:55 +0530 Message-Id: <1505998075-12969-1-git-send-email-allen.lkml@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use setup_timer function instead of initializing timer with the function and data fields. Signed-off-by: Allen Pais --- drivers/net/wan/hdlc_fr.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/wan/hdlc_fr.c b/drivers/net/wan/hdlc_fr.c index 78596e4..425a47f 100644 --- a/drivers/net/wan/hdlc_fr.c +++ b/drivers/net/wan/hdlc_fr.c @@ -1003,11 +1003,10 @@ static void fr_start(struct net_device *dev) state(hdlc)->n391cnt = 0; state(hdlc)->txseq = state(hdlc)->rxseq = 0; - init_timer(&state(hdlc)->timer); + setup_timer(&state(hdlc)->timer, fr_timer, + (unsigned long)dev); /* First poll after 1 s */ state(hdlc)->timer.expires = jiffies + HZ; - state(hdlc)->timer.function = fr_timer; - state(hdlc)->timer.data = (unsigned long)dev; add_timer(&state(hdlc)->timer); } else fr_set_link_state(1, dev); -- 2.7.4