From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752167AbdIVLRC (ORCPT ); Fri, 22 Sep 2017 07:17:02 -0400 Received: from mail-pg0-f66.google.com ([74.125.83.66]:34745 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752150AbdIVLQ6 (ORCPT ); Fri, 22 Sep 2017 07:16:58 -0400 X-Google-Smtp-Source: AOwi7QB4q/2ri4BHupOPJq5iQqPFIwadpHgreFWC0rOBcD3R1AyR1uck7qRJhbcynzdydFsb93I0HA== From: Allen Pais To: linux-kernel@vger.kernel.org Cc: ed.cashin@acm.org, Allen Pais Subject: [PATCH 4/5] block: umem: use setup_timer() helper. Date: Fri, 22 Sep 2017 16:46:38 +0530 Message-Id: <1506078999-4723-5-git-send-email-allen.lkml@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1506078999-4723-1-git-send-email-allen.lkml@gmail.com> References: <1506078999-4723-1-git-send-email-allen.lkml@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use setup_timer function instead of initializing timer with the function and data fields. Signed-off-by: Allen Pais --- drivers/block/umem.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/block/umem.c b/drivers/block/umem.c index 0677d25..b4d4ccf 100644 --- a/drivers/block/umem.c +++ b/drivers/block/umem.c @@ -738,8 +738,7 @@ static void check_all_batteries(unsigned long ptr) static void init_battery_timer(void) { - init_timer(&battery_timer); - battery_timer.function = check_all_batteries; + setup_timer(&battery_timer, check_all_batteries, 0UL); battery_timer.expires = jiffies + (HZ * 60); add_timer(&battery_timer); } -- 2.7.4