mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Allen Pais <allen.lkml@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: ed.cashin@acm.org, Allen Pais <allen.lkml@gmail.com>
Subject: [PATCH 5/5] block: DAC960: use setup_timer() helper.
Date: Fri, 22 Sep 2017 16:46:39 +0530	[thread overview]
Message-ID: <1506078999-4723-6-git-send-email-allen.lkml@gmail.com> (raw)
In-Reply-To: <1506078999-4723-1-git-send-email-allen.lkml@gmail.com>

   Use setup_timer function instead of initializing timer with the
   function and data fields.

Signed-off-by: Allen Pais <allen.lkml@gmail.com>
---
 drivers/block/DAC960.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/block/DAC960.c b/drivers/block/DAC960.c
index 255591a..83dc8ca 100644
--- a/drivers/block/DAC960.c
+++ b/drivers/block/DAC960.c
@@ -3079,11 +3079,10 @@ DAC960_InitializeController(DAC960_Controller_T *Controller)
       /*
 	Initialize the Monitoring Timer.
       */
-      init_timer(&Controller->MonitoringTimer);
+	setup_timer(&Controller->MonitoringTimer,
+		  DAC960_MonitoringTimerFunction, (unsigned long)Controller);
       Controller->MonitoringTimer.expires =
 	jiffies + DAC960_MonitoringTimerInterval;
-      Controller->MonitoringTimer.data = (unsigned long) Controller;
-      Controller->MonitoringTimer.function = DAC960_MonitoringTimerFunction;
       add_timer(&Controller->MonitoringTimer);
       Controller->ControllerInitialized = true;
       return true;
-- 
2.7.4

      parent reply	other threads:[~2017-09-22 11:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-22 11:16 [PATCH 0/5] use setup_timer() helper function Allen Pais
2017-09-22 11:16 ` [PATCH 1/5] block: amiflop: use setup_timer() helper Allen Pais
2017-09-22 11:16 ` [PATCH 2/5] block: aoe: " Allen Pais
2017-09-22 11:16 ` [PATCH 3/5] " Allen Pais
2017-09-22 11:16 ` [PATCH 4/5] block: umem: " Allen Pais
2017-09-22 11:16 ` Allen Pais [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1506078999-4723-6-git-send-email-allen.lkml@gmail.com \
    --to=allen.lkml@gmail.com \
    --cc=ed.cashin@acm.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®