From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752005AbdIXKfa (ORCPT ); Sun, 24 Sep 2017 06:35:30 -0400 Received: from smtprelay0020.hostedemail.com ([216.40.44.20]:38291 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751740AbdIXKf2 (ORCPT ); Sun, 24 Sep 2017 06:35:28 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::,RULES_HIT:41:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:2899:3138:3139:3140:3141:3142:3350:3622:3870:3873:3876:4321:5007:10004:10400:10471:10848:11026:11232:11657:11658:11914:12043:12048:12114:12296:12438:12740:12760:12895:13069:13095:13255:13311:13357:13439:14659:14721:21080:21212:21433:21627:30054:30083:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: berry22_2f4904fe1ac47 X-Filterd-Recvd-Size: 1800 Message-ID: <1506249323.11186.3.camel@perches.com> Subject: Re: [PATCH 1/6] [media] omap_vout: Delete an error message for a failed memory allocation in omap_vout_create_video_devices() From: Joe Perches To: SF Markus Elfring , linux-media@vger.kernel.org, Hans Verkuil , Jan Kara , Lorenzo Stoakes , Mauro Carvalho Chehab , Michal Hocko , Muralidharan Karicheri Cc: LKML , kernel-janitors@vger.kernel.org Date: Sun, 24 Sep 2017 03:35:23 -0700 In-Reply-To: References: Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2017-09-24 at 12:22 +0200, SF Markus Elfring wrote: > Omit an extra message for a memory allocation failure in this function. [] > diff --git a/drivers/media/platform/omap/omap_vout.c b/drivers/media/platform/omap/omap_vout.c [] > @@ -1948,7 +1948,5 @@ static int __init omap_vout_create_video_devices(struct platform_device *pdev) > - if (!vout) { > - dev_err(&pdev->dev, ": could not allocate memory\n"); > + if (!vout) > return -ENOMEM; > - } > > vout->vid = k; > vid_dev->vouts[k] = vout; Use normal patch styles. Fix your tools before you send any more patches.