From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965982AbdIZGzJ (ORCPT ); Tue, 26 Sep 2017 02:55:09 -0400 Received: from LGEAMRELO11.lge.com ([156.147.23.51]:54776 "EHLO lgeamrelo11.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935006AbdIZGzH (ORCPT ); Tue, 26 Sep 2017 02:55:07 -0400 X-Original-SENDERIP: 156.147.1.125 X-Original-MAILFROM: byungchul.park@lge.com X-Original-SENDERIP: 10.177.222.33 X-Original-MAILFROM: byungchul.park@lge.com From: Byungchul Park To: peterz@infradead.org, mingo@kernel.org Cc: linux-kernel@vger.kernel.org, kernel-team@lge.com, ying.huang@intel.com Subject: [PATCH] llist: Put parentheses around parameters of llist_for_each_entry_safe() Date: Tue, 26 Sep 2017 15:54:51 +0900 Message-Id: <1506408891-27460-1-git-send-email-byungchul.park@lge.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It would be somewhat safer to put parentheses around parameters of a macro with parameters. Put it. Signed-off-by: Byungchul Park --- include/linux/llist.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/linux/llist.h b/include/linux/llist.h index 1957635..e280b297 100644 --- a/include/linux/llist.h +++ b/include/linux/llist.h @@ -183,10 +183,10 @@ static inline void init_llist_head(struct llist_head *list) * reverse the order by yourself before traversing. */ #define llist_for_each_entry_safe(pos, n, node, member) \ - for (pos = llist_entry((node), typeof(*pos), member); \ + for ((pos) = llist_entry((node), typeof(*(pos)), member); \ member_address_is_nonnull(pos, member) && \ - (n = llist_entry(pos->member.next, typeof(*n), member), true); \ - pos = n) + ((n) = llist_entry((pos)->member.next, typeof(*(n)), member), true); \ + (pos) = (n)) /** * llist_empty - tests whether a lock-less list is empty -- 1.9.1