mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: kan.liang@intel.com
To: acme@kernel.org, peterz@infradead.org, mingo@redhat.com,
	linux-kernel@vger.kernel.org
Cc: jolsa@kernel.org, namhyung@kernel.org, adrian.hunter@intel.com,
	lukasz.odzioba@intel.com, wangnan0@huawei.com,
	hekuang@huawei.com, ast@kernel.org, ak@linux.intel.com,
	Kan Liang <kan.liang@intel.com>
Subject: [PATCH RFC V4 6/6] perf top: check the cost of perf_top__mmap_read
Date: Fri, 29 Sep 2017 07:47:57 -0700	[thread overview]
Message-ID: <1506696477-146932-7-git-send-email-kan.liang@intel.com> (raw)
In-Reply-To: <1506696477-146932-1-git-send-email-kan.liang@intel.com>

From: Kan Liang <kan.liang@intel.com>

The latency of perf_top__mmap_read should be lower than refresh time.
If not, give some hints to reduce the overhead.

Signed-off-by: Kan Liang <kan.liang@intel.com>
---
 tools/perf/builtin-top.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
index 03090d0..b5143c9 100644
--- a/tools/perf/builtin-top.c
+++ b/tools/perf/builtin-top.c
@@ -863,11 +863,20 @@ static void perf_top__mmap_read_idx(struct perf_top *top, int idx)
 
 static void perf_top__mmap_read(struct perf_top *top)
 {
+	unsigned long long s, e;
 	int i;
 
 	perf_evlist__toggle_bkw_mmap(top->evlist, BKW_MMAP_DATA_PENDING);
+	s = rdclock();
 	for (i = 0; i < top->evlist->nr_mmaps; i++)
 		perf_top__mmap_read_idx(top, i);
+	e = rdclock();
+	if ((e - s) > (unsigned long long)(top->delay_secs * NSEC_PER_SEC)) {
+		ui__warning("Too slow to read ring buffer.\n"
+			    "Please try increasing the period (-c) or\n"
+			    "decreasing the freq (-F) or\n"
+			    "limiting the number of CPUs (-C)\n");
+	}
 	perf_evlist__toggle_bkw_mmap(top->evlist, BKW_MMAP_EMPTY);
 	perf_evlist__toggle_bkw_mmap(top->evlist, BKW_MMAP_RUNNING);
 }
-- 
2.5.5

      parent reply	other threads:[~2017-09-29 14:48 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-29 14:47 [PATCH RFC V4 0/6] perf top optimization kan.liang
2017-09-29 14:47 ` [PATCH RFC V4 1/6] perf tools: lock to protect namespaces and comm list kan.liang
2017-10-02 18:05   ` Arnaldo Carvalho de Melo
2017-10-02 19:14     ` Liang, Kan
2017-10-02 19:34       ` Arnaldo Carvalho de Melo
2017-10-03 16:44   ` [tip:perf/core] perf tools: Lock " tip-bot for Kan Liang
2017-09-29 14:47 ` [PATCH RFC V4 2/6] perf tools: lock to protect comm_str rb tree kan.liang
2017-10-03 16:45   ` [tip:perf/core] perf tools: Lock " tip-bot for Kan Liang
2017-09-29 14:47 ` [PATCH RFC V4 3/6] perf top: implement multithreading for perf_event__synthesize_threads kan.liang
2017-10-03 16:45   ` [tip:perf/core] perf top: Implement " tip-bot for Kan Liang
2017-09-29 14:47 ` [PATCH RFC V4 4/6] perf top: add option to set the number of thread for event synthesize kan.liang
2017-10-03 16:45   ` [tip:perf/core] perf top: Add " tip-bot for Kan Liang
2017-09-29 14:47 ` [PATCH RFC V4 5/6] perf top: switch to backward overwrite mode kan.liang
2017-09-30 19:48   ` Jiri Olsa
2017-10-02 17:19     ` Liang, Kan
2017-10-02 18:03       ` acme
2017-10-03  8:24       ` Jiri Olsa
2017-09-29 14:47 ` kan.liang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1506696477-146932-7-git-send-email-kan.liang@intel.com \
    --to=kan.liang@intel.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=ak@linux.intel.com \
    --cc=ast@kernel.org \
    --cc=hekuang@huawei.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukasz.odzioba@intel.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=wangnan0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome