From: Doug Ledford <dledford@redhat.com>
To: Colin King <colin.king@canonical.com>,
Lijun Ou <oulijun@huawei.com>, Wei Hu <xavier.huwei@huawei.com>,
Sean Hefty <sean.hefty@intel.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>,
linux-rdma@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][rdma-next] RDMA/hns: make various function static, fixes warnings
Date: Fri, 29 Sep 2017 11:27:15 -0400 [thread overview]
Message-ID: <1506698835.2919.20.camel@redhat.com> (raw)
In-Reply-To: <20170929131601.7111-1-colin.king@canonical.com>
On Fri, 2017-09-29 at 14:16 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The functions hns_roce_table_mhop_get, hns_roce_table_mhop_put,
> hns_roce_cleanup_mhop_hem_table, hns_roce_v1_post_mbox,
> hns_roce_cmq_setup_basic_desc, hns_roce_cmq_send,
> hns_roce_cmq_query_hw_info are all local to the source and do
> not need to be in global scope, so make them static.
>
> Cleans up sparse warnings:
> symbol 'hns_roce_table_mhop_get' was not declared. Should it be
> static?
> symbol 'hns_roce_table_mhop_put' was not declared. Should it be
> static?
> symbol 'hns_roce_cleanup_mhop_hem_table' was not declared. Should it
> be
> static?
> symbol 'hns_roce_v1_post_mbox' was not declared. Should it be static?
> symbol 'hns_roce_cmq_setup_basic_desc' was not declared. Should it be
> static?
> symbol 'hns_roce_cmq_send' was not declared. Should it be static?
> symbol 'hns_roce_cmq_query_hw_info' was not declared. Should it be
> static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Thanks, applied.
--
Doug Ledford <dledford@redhat.com>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
prev parent reply other threads:[~2017-09-29 15:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-29 13:16 Colin King
2017-09-29 15:27 ` Doug Ledford [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1506698835.2919.20.camel@redhat.com \
--to=dledford@redhat.com \
--cc=colin.king@canonical.com \
--cc=hal.rosenstock@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=oulijun@huawei.com \
--cc=sean.hefty@intel.com \
--cc=xavier.huwei@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome