From: Shreeya Patel <shreeya.patel23498@gmail.com>
To: "Tobin C. Harding" <me@tobin.cc>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com
Subject: Re: [PATCH v2] Staging: rtl8723bs: Remove unnecessary comments.
Date: Sat, 30 Sep 2017 16:43:52 +0530 [thread overview]
Message-ID: <1506770032.2078.1.camel@gmail.com> (raw)
In-Reply-To: <20170930110657.GA25277@eros>
On Sat, 2017-09-30 at 21:06 +1000, Tobin C. Harding wrote:
> Hi Shreeya,
>
> We don't usually add a period to the subject line for kernel patches.
> (reason: we only have about
> 52 characters for the commit brief description so best not to waste
> any).
>
> On Sat, Sep 30, 2017 at 01:30:34PM +0530, Shreeya Patel wrote:
> >
> > This patch removes unnecessary comments which are there
> > to explain why call to memset is in comments. Both of the
> > comments are not needed as they are not very useful.
> You may like to read Documentation/process/submitting-patches.rst
> (specifically
> section 2) for tips on writing your git log.
>
> Describe your changes in imperative mood, e.g. "make xyzzy do
> frotz"
> instead of "[This patch] makes xyzzy do frotz" or "[I]
> changed xyzzy
> to do frotz", as if you are giving orders to the codebase to
> change
> its behaviour.
>
> Good luck,
> Tobin.
Hello,
Thanks for correcting me :)
I'll do the necessary changes and will send as v3.
prev parent reply other threads:[~2017-09-30 11:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-30 8:00 Shreeya Patel
2017-09-30 11:06 ` Tobin C. Harding
2017-09-30 11:13 ` Shreeya Patel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1506770032.2078.1.camel@gmail.com \
--to=shreeya.patel23498@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=me@tobin.cc \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome