From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751012AbdJAHpg (ORCPT ); Sun, 1 Oct 2017 03:45:36 -0400 Received: from mail-pg0-f68.google.com ([74.125.83.68]:34801 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750849AbdJAHpf (ORCPT ); Sun, 1 Oct 2017 03:45:35 -0400 X-Google-Smtp-Source: AOwi7QDI8YyrsdmK+/7c8B/68HKm04GvTlXxTK6+OxRboVujf8hqa6y+4PObqhNSfMuJc8Wwdw5nog== Message-ID: <1506843929.2680.1.camel@gmail.com> Subject: Re: [PATCH v3] Staging: rtl8723bs: Remove unnecessary comments. From: Shreeya Patel To: "Tobin C. Harding" Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com Date: Sun, 01 Oct 2017 13:15:29 +0530 In-Reply-To: <20170930224205.GA29392@eros> References: <1506780671-2209-1-git-send-email-shreeya.patel23498@gmail.com> <20170930224205.GA29392@eros> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.2-0ubuntu3.2 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2017-10-01 at 09:42 +1100, Tobin C. Harding wrote: > On Sat, Sep 30, 2017 at 07:41:11PM +0530, Shreeya Patel wrote: > > > > Remove unnecessary comments which are there > > to explain why call to memset is in comments. Both of the > > comments are not needed as they are not very useful. > > > > > > Signed-off-by: Shreeya Patel > > --- > > Changes in v2: > >   -Remove some more unnecessary comments and make the > >    commit message more appropriate. > > > > Changes in v3: > >   -Make the commit message in imperative form. > Well done. You forgot the period on the commit subject. Here is a > blog post you might like (it is > not kernel specific but useful still IMO). > > Good luck, > Tobin. I did the necessary changes and have sent it as v4. Thanks. > > > > >  drivers/staging/rtl8723bs/core/rtw_mlme.c     | 3 --- > >  drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 3 --- > >  drivers/staging/rtl8723bs/core/rtw_pwrctrl.c  | 2 -- > >  drivers/staging/rtl8723bs/core/rtw_recv.c     | 4 ---- > >  drivers/staging/rtl8723bs/core/rtw_xmit.c     | 3 --- > >  5 files changed, 15 deletions(-) > > > > diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c > > b/drivers/staging/rtl8723bs/core/rtw_mlme.c > > index 6b77820..5b583f7 100644 > > --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c > > +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c > > @@ -28,9 +28,6 @@ sint _rtw_init_mlme_priv(struct adapter > > *padapter) > >   struct mlme_priv  *pmlmepriv = &padapter->mlmepriv; > >   sint res = _SUCCESS; > >   > > - /*  We don't need to memset padapter->XXX to zero, because > > adapter is allocated by vzalloc(). */ > > - /* memset((u8 *)pmlmepriv, 0, sizeof(struct mlme_priv)); > > */ > > - > >   pmlmepriv->nic_hdl = (u8 *)padapter; > >   > >   pmlmepriv->pscanned = NULL; > > diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c > > b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c > > index b6d137f..ca35c1c 100644 > > --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c > > +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c > > @@ -474,9 +474,6 @@ int init_mlme_ext_priv(struct adapter > > *padapter) > >   struct mlme_priv *pmlmepriv = &(padapter->mlmepriv); > >   struct mlme_ext_info *pmlmeinfo = &(pmlmeext- > > >mlmext_info); > >   > > - /*  We don't need to memset padapter->XXX to zero, because > > adapter is allocated by vzalloc(). */ > > - /* memset((u8 *)pmlmeext, 0, sizeof(struct > > mlme_ext_priv)); */ > > - > >   pmlmeext->padapter = padapter; > >   > >   /* fill_fwpriv(padapter, &(pmlmeext->fwpriv)); */ > > diff --git a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c > > b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c > > index aabdaaf..820a061 100644 > > --- a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c > > +++ b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c > > @@ -1193,8 +1193,6 @@ void rtw_init_pwrctrl_priv(struct adapter > > *padapter) > >   > >  void rtw_free_pwrctrl_priv(struct adapter *adapter) > >  { > > - /* memset((unsigned char *)pwrctrlpriv, 0, sizeof(struct > > pwrctrl_priv)); */ > > - > >  #ifdef CONFIG_PNO_SUPPORT > >   if (pwrctrlpriv->pnlo_info != NULL) > >   printk("****** pnlo_info memory leak********\n"); > > diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c > > b/drivers/staging/rtl8723bs/core/rtw_recv.c > > index 68a6303..73e6e41 100644 > > --- a/drivers/staging/rtl8723bs/core/rtw_recv.c > > +++ b/drivers/staging/rtl8723bs/core/rtw_recv.c > > @@ -46,9 +46,6 @@ sint _rtw_init_recv_priv(struct recv_priv > > *precvpriv, struct adapter *padapter) > >   union recv_frame *precvframe; > >   sint res = _SUCCESS; > >   > > - /*  We don't need to memset padapter->XXX to zero, because > > adapter is allocated by vzalloc(). */ > > - /* memset((unsigned char *)precvpriv, 0, sizeof > > (struct  recv_priv)); */ > > - > >   spin_lock_init(&precvpriv->lock); > >   > >   _rtw_init_queue(&precvpriv->free_recv_queue); > > @@ -65,7 +62,6 @@ sint _rtw_init_recv_priv(struct recv_priv > > *precvpriv, struct adapter *padapter) > >   res = _FAIL; > >   goto exit; > >   } > > - /* memset(precvpriv->pallocated_frame_buf, 0, NR_RECVFRAME > > * sizeof(union recv_frame) + RXFRAME_ALIGN_SZ); */ > >   > >   precvpriv->precv_frame_buf = (u8 > > *)N_BYTE_ALIGMENT((SIZE_PTR)(precvpriv->pallocated_frame_buf), > > RXFRAME_ALIGN_SZ); > >   /* precvpriv->precv_frame_buf = precvpriv- > > >pallocated_frame_buf + RXFRAME_ALIGN_SZ - */ > > diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c > > b/drivers/staging/rtl8723bs/core/rtw_xmit.c > > index 022f654..8cd05f8 100644 > > --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c > > +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c > > @@ -51,9 +51,6 @@ s32 _rtw_init_xmit_priv(struct xmit_priv > > *pxmitpriv, struct adapter *padapter) > >   struct xmit_frame *pxframe; > >   sint res = _SUCCESS; > >   > > - /*  We don't need to memset padapter->XXX to zero, because > > adapter is allocated by vzalloc(). */ > > - /* memset((unsigned char *)pxmitpriv, 0, sizeof(struct > > xmit_priv)); */ > > - > >   spin_lock_init(&pxmitpriv->lock); > >   spin_lock_init(&pxmitpriv->lock_sctx); > >   sema_init(&pxmitpriv->xmit_sema, 0);