From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751065AbdJBKA2 (ORCPT ); Mon, 2 Oct 2017 06:00:28 -0400 Received: from smtprelay0022.hostedemail.com ([216.40.44.22]:54135 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750891AbdJBKA1 (ORCPT ); Mon, 2 Oct 2017 06:00:27 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::,RULES_HIT:41:355:379:541:599:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1714:1730:1747:1777:1792:2198:2199:2393:2559:2562:2828:3138:3139:3140:3141:3142:3351:3622:3865:3867:3868:3870:3872:4250:4321:5007:10004:10400:10848:11026:11232:11473:11658:11914:12043:12296:12740:12760:12895:13069:13161:13229:13311:13357:13439:14659:14721:21080:21451:21611:21627:30029:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: aunt86_3dc3b53682d60 X-Filterd-Recvd-Size: 1719 Message-ID: <1506938422.2274.11.camel@perches.com> Subject: Re: [PATCH 2/4] staging: ccree: simplify access to struct device From: Joe Perches To: Gilad Ben-Yossef , Greg Kroah-Hartman Cc: Ofir Drang , linux-crypto@vger.kernel.org, driverdev-devel@linuxdriverproject.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Mon, 02 Oct 2017 03:00:22 -0700 In-Reply-To: <1506935008-14240-3-git-send-email-gilad@benyossef.com> References: <1506935008-14240-1-git-send-email-gilad@benyossef.com> <1506935008-14240-3-git-send-email-gilad@benyossef.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2017-10-02 at 10:03 +0100, Gilad Ben-Yossef wrote: > Introduce a DEV macro to retrieve struct device from private > data structure in preparation to replacing custom logging > macros with proper dev_dbg and friends which require struct > device. [] > diff --git a/drivers/staging/ccree/ssi_driver.h b/drivers/staging/ccree/ssi_driver.h [] > @@ -103,6 +103,8 @@ > #define SSI_LOG_DEBUG(format, ...) do {} while (0) > #endif > > +#define DEV(drvdata) ((&(drvdata)->plat_dev->dev)) The name seems not particularly descriptive. It seems a longer name would not be too bad. Perhaps static inline struct device *drvdata_to_dev(struct ssi_drvdata *drvdata) { return &drvdata->plat_dev->dev; }