From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751179AbdJBKbo (ORCPT ); Mon, 2 Oct 2017 06:31:44 -0400 Received: from mail-by2nam01on0047.outbound.protection.outlook.com ([104.47.34.47]:51410 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750983AbdJBKbm (ORCPT ); Mon, 2 Oct 2017 06:31:42 -0400 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=fail action=none header.from=nxp.com; From: Madalin Bucur To: , , CC: Subject: [PATCH] fsl/fman: remove of_node Date: Mon, 2 Oct 2017 13:31:37 +0300 Message-ID: <1506940297-20442-1-git-send-email-madalin.bucur@nxp.com> X-Mailer: git-send-email 2.1.0 Reply-To: X-EOPAttributedMessage: 0 X-Matching-Connectors: 131514139010348370;(91ab9b29-cfa4-454e-5278-08d120cd25b8);() X-Forefront-Antispam-Report: CIP:192.88.158.2;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(336005)(39380400002)(346002)(39860400002)(376002)(2980300002)(1110001)(1109001)(339900001)(199003)(189002)(85426001)(110136005)(106466001)(104016004)(105606002)(2201001)(53936002)(8936002)(305945005)(50226002)(8676002)(97736004)(4326008)(39060400002)(81166006)(16586007)(189998001)(316002)(36756003)(81156014)(68736007)(47776003)(50986999)(5003940100001)(3450700001)(356003)(48376002)(498600001)(43066003)(86362001)(2906002)(77096006)(5660300001)(69596002)(33646002)(50466002);DIR:OUT;SFP:1101;SCL:1;SRVR:SN2PR03MB2367;H:az84smr01.freescale.net;FPR:;SPF:Fail;PTR:InfoDomainNonexistent;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN1AFFO11FD028;1:21lO0rg/ako6pec0rnt/s2R62EbO4WRWk/Tb6d+JMz6cBf8MvgUCKDqNDz4FDm3dv25vE/FlOHWhX4CTrwNNtfh9/BsLDjQKd1YKkob5aEJd97mVWBR1AxeXHwAp1T7y MIME-Version: 1.0 Content-Type: text/plain X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 20fb9bc3-1006-4c18-d3f1-08d50980c51b X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017052603199)(201703131430075)(201703131517081);SRVR:SN2PR03MB2367; X-Microsoft-Exchange-Diagnostics: 1;SN2PR03MB2367;3:nnrOeQYqi3gMvlJbsQqrdtnsPSSGoWmqACoZXsndwxPLPKMCHXwI/1fxDGVWtax89VMym/TwkRGb9kJhOzZruXOvT+VlbRZSzxyby8mEDnQLhn06sClHvaTIyWQlNBGueTHykOBI0+AYTFClyO7eTQ7PWXcHPBgYJwlF9tXTJQu+gHYPL/6g2KDCCjPsWqbSQb/XjXbGlHmipXsAG6qD/UcH0yHPlfhrCkuiX492cY/XTODxc77WSymwsFB8CyA6h9tBQaKhbZnHTq6E1SarvDNAqK9zGNus3I5k5m/L+IRvxX2ICLMijyzrC+Hx/uhVx0nV65atP33k/PZMVsyrTtHqKln4pgOVHZbtEQdSin8=;25:BuIsX+tEkvZXUZKshkBfmDKJcVsalLw18Z49nN0Zr1ZUdRUdEol2zwuEvrdVm8Egn6KbI99ifM7FuYioS/Nt3UFrdyln756GsUk4NRhQxJUTRk0GT9Wym9jAxD7dy5qPZZvuQvrDi8OLMsCYKeShOs+YwR1ZDNPga6i7WfIznfw/ExzheGq5sesZW4QLW16iXfh5ew0gZFffc7M5t9KO8wQNgUBSTifu9pSehSoxROY4HwmHTWKEunCq3jyVVtB6X7JYPh23V88K6yoyAdHhP4JqHL2fRBMZVf3K0Z2Jsy2sqiB2FfZ645qroF1hbLSfCXYaF1gr7I1iVziEYep4GQ== X-MS-TrafficTypeDiagnostic: SN2PR03MB2367: X-Microsoft-Exchange-Diagnostics: 1;SN2PR03MB2367;31:K37usqVxeNia8D5SH03sNAZno9QqfyU4QWT3WjBZdCH5PBuNZI7HVzxXeRCrOau61eO47UOj/b6c3eeNJ5Y67eG4UtzUD8XpGaj59nchfTyURkBjksojEjRS5io70zWBME6fGd4ywL0tfQcJ59eXfWteY79AvsFr951VgNs7aeAEjUQLkF4zc/L60KEcz3qCyua7Cj6+itY0gdgYL7bQeZ0xsl9eMKhFcfNtepCHgZM=;4:Jr3RmXLiMZPat2ofEdV99eCFhiBbAP+R/WatX/IoNcQPFu9MsTKYxmokZi+njpgU6G0y0YthIf0YLJ0zgJoaID2c/WcPZH25WaYtlxjNHHDzs8I8/Sk2hiAVx6tqP0kzPkD8unT447qb4HUS1tTnHWf79gP9JNiP+Z+IanqLAYbu3xbQAvFAlVFpI0D6o7FKYEm93/aJo4TuCleAVkI4249Z22mvayKETvR1JcZjaKFBfbInKyLPdIEBtUNVSxAliUCvGdQ6orgTAOc3+QK2+o01ZASdT5S3hzywpqP/RRs= X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(100000703101)(100105400095)(10201501046)(6055026)(6096035)(20161123556025)(20161123565025)(20161123561025)(20161123563025)(20161123559100)(201703131430075)(201703131433075)(201703131448075)(201703161259150)(201703151042153)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:SN2PR03MB2367;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:SN2PR03MB2367; X-Forefront-PRVS: 0448A97BF2 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;SN2PR03MB2367;23:clAI2d6lY3wh4fzSkgrlRpOdmvr6EcJt4rSoLQEU6?= =?us-ascii?Q?yjMHuExqebgJ/PiB8pXzYmw41I7qKP6rzb5qrfNi1+5eOrNAa1hGDw0KL7NI?= =?us-ascii?Q?fXOdNrx0/UvOywsqmyvwi17YzYbPPXe+YV+dH/bdCut97NoA+lTJTd+e93/A?= =?us-ascii?Q?uHO8Eja4vpFRHa383dhNFfjNSxAMo7WqSsEVZ00igIF4WG/4fiIuZcEXKNy9?= =?us-ascii?Q?haxHKZIT+Np7G5cEsnkS5XWVTKxf5g7TJSrY2lanMMpzjV/I+Q32oL6JN8Aj?= =?us-ascii?Q?0CGwwzyVyY0hvsUBTUz9l/I8Wgex0ISaOpaGVbFLf18WQN3b33xbU14qfkPp?= =?us-ascii?Q?Pd6J+3pqEUHKWqZ8SUQO3BxTFYI8SDzXMIE1Xouq2PZ4LoaKcPQEyNrlof8A?= =?us-ascii?Q?+dW9KZFpglMF5muPfcDD3Rbe3tObOWbJnuj48N0QoACeDAtaCXMTVqHerpMl?= =?us-ascii?Q?Ow/rmSFUvw6og9nMywWGWJF7n9EE2v8bz4j8YN5QM5RlhlVA2OCtzk3nFZ0x?= =?us-ascii?Q?xWHg58SP9ouDH1mbzVtQVugB0iRpPbtjIP9OUHqfjkWKuFhvrSph0ptHHjaX?= =?us-ascii?Q?ATyt7XRMGG5lpJRXwVsDTe32SwG8a6xWPbR/Pf69RYofBgZgs9H+oChKgoAe?= =?us-ascii?Q?fMjXxgcFSexQVbkAl/WPwpqQDRGiwwPOcUqB1Xa9oWxDiBrp9PudWGmKh8r8?= =?us-ascii?Q?BACMkcU13F3idmDolbxodSvC5xGFkPXoWj40jzWSgvNe25LqIRzQ3SYkD6n6?= =?us-ascii?Q?wRWAKAVmN4Dqvu6qgR/NX6fg5jCOqwVFG/qVCRZnIN5Dmy7N8j0ZMz+Bc0YU?= =?us-ascii?Q?rUKgSMCEeKJI4I2agDB3FEAnzmCp+d3rFq4lPg2DUS1QMb4BphGBkrjYlYt5?= =?us-ascii?Q?rb5XUU43/LDpQlQ0ovIN78av2aDK4H0pFgIIaeCJT0Gu42ckSygQgWeeKPhd?= =?us-ascii?Q?P5InWeTmf+Bp8MaBy29FXKPoHZfuv7z6Hx+JaLMIyLnR2KLr8/VDUMTgXEbu?= =?us-ascii?Q?CgoBk3Fbe7sIV85tGZr04XtPkAnoW+Udi8DhO6uR/riFSGs21jqMBHIr2zZc?= =?us-ascii?Q?O1/ysYLOI6YpcGVWSi0RnLhbJs2dFWIAUn0tYJeLXlh45DZ0q11UbYb/idw4?= =?us-ascii?Q?qRs9HUJ7DFcTMuGkLmW4EXLp9CspPCJERGKyKpHBdyMAhMNwLeqqQ=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;SN2PR03MB2367;6:SVjSDqHIaNNnJF/ZU+3C+LnDwabgABpnPCYlIqbEQjSF9/vUVg9lEH7piTw3DiTF584kNGRGeYYI4AJmxcVb35q+xiZqh8ttc3TVU5y5XvfwSu9XrBBEVGB4idey9FGKMsFK3RV4DU2KdpTzfy6CDTkJV6ndWBNxdVdO43eZ1G4Hq2p3TBxkXzK4j5WOD2BI/FPhiu2hZMI9aAk3p7jOeYfrrKrYfYgQtNE+6Xm8rXHLlY0eVDirCPd9LmjV2WQjVmDTYB9FBt3skiAnrwF1YY2xjyqYAfWaDUdVju6WN0mja/2EzqpM+BZf5RSDHAGq5+PI3JVOWH7j7dr55u/nzQ==;5:7ow7iw5dD1lgYyg0RVf3fNPtqZtpufVI31XuCNUokJzhaurXzTq9oGJqag3YFRJxCDLDiVgzTHY7EDAPZh7HtipKsFT+90Ky346IbiCFKuca2qx3r9dqRTGdl1VOlh68mA58xsxAaFJyvYYJQiElSA==;24:MC1tAN5I5gknuu7inzex+YKJgQLNbFgHFu9rtp4Lc29v6BjvnU0VEO0iCa+7umkjdoViGPeradbMynvxEcSjm1zSn9W+sxOVrCCxMqXkkDU=;7:7AHK0GVp6tcXuZZTQ+VhKtgwZRdpHmkcfhvOlfPYaFfEl4R0QItZ+g/dT9cw0TSFikhuYW/p/TTdijcU31pqXxaJu2unY/dSi/YBwfAu/tLoE8l4e2mGuCOt2ftdGBCB8sjNabx1AoL0IozjGc2gWMjF6wDTGSn+YnKcAgHBWfMoKTHDKYVDTN1gSBDxgBvAWE/uoxv1XhJvEjPy3qGfzQL0fctQn5corT+ibdmnFk0= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Oct 2017 10:31:40.7852 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;Ip=[192.88.158.2];Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR03MB2367 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The FMan MAC driver allocates a platform device for the Ethernet driver to probe on. Setting pdev->dev.of_node with the MAC node triggers the MAC driver probing of the new platform device. While this fails quickly and does not affect the functionality of the drivers, it is incorrect and must be removed. This was added to address a report that DSA code using of_find_net_device_by_node() is unable to use the DPAA interfaces. Error message seen before this fix: fsl_mac dpaa-ethernet.0: __devm_request_mem_region(mac) failed fsl_mac: probe of dpaa-ethernet.0 failed with error -16 Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/fman/mac.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/fman/mac.c b/drivers/net/ethernet/freescale/fman/mac.c index 387eb4a..9a265f8 100644 --- a/drivers/net/ethernet/freescale/fman/mac.c +++ b/drivers/net/ethernet/freescale/fman/mac.c @@ -623,7 +623,6 @@ static struct platform_device *dpaa_eth_add_device(int fman_id, goto no_mem; } - pdev->dev.of_node = node; pdev->dev.parent = priv->dev; set_dma_ops(&pdev->dev, get_dma_ops(priv->dev)); -- 2.1.0