From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751204AbdJBM1j (ORCPT ); Mon, 2 Oct 2017 08:27:39 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:49329 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751075AbdJBM1i (ORCPT ); Mon, 2 Oct 2017 08:27:38 -0400 Message-ID: <1506947253.9752.3.camel@pengutronix.de> Subject: Re: [PATCH] dt-bindings: fsl-imx-drm: Remove incorrect "@di0" usage From: Philipp Zabel To: Marco Franchi Cc: robh+dt@kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, festevam@gmail.com, marcofrk@gmail.com Date: Mon, 02 Oct 2017 14:27:33 +0200 In-Reply-To: <1506103553-31366-1-git-send-email-marco.franchi@nxp.com> References: <1506103553-31366-1-git-send-email-marco.franchi@nxp.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Marco, On Fri, 2017-09-22 at 15:05 -0300, Marco Franchi wrote: > Improve the binding example by removing the '@di0' notation, which > fixes the following build warning: > > Warning (unit_address_vs_reg): Node /display@di0 has a unit name, but  > no reg property > > Signed-off-by: Marco Franchi > --- >  Documentation/devicetree/bindings/display/imx/fsl-imx-drm.txt | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/display/imx/fsl-imx- > drm.txt b/Documentation/devicetree/bindings/display/imx/fsl-imx- > drm.txt > index f798547..44814f0 100644 > --- a/Documentation/devicetree/bindings/display/imx/fsl-imx-drm.txt > +++ b/Documentation/devicetree/bindings/display/imx/fsl-imx-drm.txt > @@ -129,7 +129,7 @@ Optional properties: >   >  example: >   > -display@di0 { > +display-di0 { >   compatible = "fsl,imx-parallel-display"; >   edid = [edid-data]; >   interface-pix-fmt = "rgb24"; Thank you for the patch. We certainly should get rid of the @di0 notation. Since these nodes mostly describe the DISP0 and DISP1 pin groups controlled by the IOMUXC, I'd prefer to rename this to -display@di0 { +disp0 { instead, if that is fine with you. I'd also like to move the disp0/disp1 nodes into the SoC dtsi files to avoid having to duplicate port@0 all over the place. regards Philipp