From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751990AbdJBQlk (ORCPT ); Mon, 2 Oct 2017 12:41:40 -0400 Received: from esa3.hgst.iphmx.com ([216.71.153.141]:14660 "EHLO esa3.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751746AbdJBQlh (ORCPT ); Mon, 2 Oct 2017 12:41:37 -0400 X-IronPort-AV: E=Sophos;i="5.42,470,1500912000"; d="scan'208";a="56014193" From: Bart Van Assche To: "linux-scsi@vger.kernel.org" , "alim.akhtar@samsung.com" , "linux-kernel@vger.kernel.org" CC: "subhashj@codeaurora.org" , "martin.petersen@oracle.com" , "vinholikatti@gmail.com" Subject: Re: [PATCH 1/3] scsi: ufs: Change HCI marco to actual bit position Thread-Topic: [PATCH 1/3] scsi: ufs: Change HCI marco to actual bit position Thread-Index: AQHTObWPebP72mOrS0GAxdaK0iEK5aLQxzGA Date: Mon, 2 Oct 2017 16:41:34 +0000 Message-ID: <1506962493.3368.35.camel@wdc.com> References: <1506752526-27014-1-git-send-email-alim.akhtar@samsung.com> In-Reply-To: <1506752526-27014-1-git-send-email-alim.akhtar@samsung.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Bart.VanAssche@wdc.com; x-originating-ip: [63.163.107.100] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;CY1PR0401MB1534;20:rWxXtuRlh8msESz+zYHXUhhXpMGtBcDrFNHBUI4nzpu7Wf4lfMG7cbfBc0mrilgppojx8WunnvMjelomFpewJTEWNBXuh+1JW0L/TRs5WShOwgzQcpEwp05l82naz37ZqNppyGq7huT5dXvkRYlypZGBZCDgyQnoaNCQqElD4u0= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 49b2a770-bbb6-4ac3-487c-08d509b47199 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(48565401081)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:CY1PR0401MB1534; x-ms-traffictypediagnostic: CY1PR0401MB1534: wdcipoutbound: EOP-TRUE x-exchange-antispam-report-test: UriScan:; x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(3002001)(10201501046)(100000703101)(100105400095)(93006095)(93001095)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123562025)(20161123560025)(20161123558100)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CY1PR0401MB1534;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CY1PR0401MB1534; x-forefront-prvs: 0448A97BF2 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(376002)(39860400002)(346002)(377424004)(189002)(24454002)(199003)(189998001)(81156014)(68736007)(4326008)(478600001)(6506006)(305945005)(6512007)(7736002)(53936002)(2201001)(3660700001)(2906002)(72206003)(316002)(99286003)(54906003)(76176999)(54356999)(50986999)(14454004)(39060400002)(3280700002)(110136005)(66066001)(101416001)(103116003)(5660300001)(2501003)(6116002)(86362001)(3846002)(102836003)(77096006)(6486002)(2900100001)(106356001)(81166006)(8676002)(105586002)(2950100002)(6436002)(6246003)(36756003)(97736004)(8936002)(33646002)(25786009)(229853002);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR0401MB1534;H:CY1PR0401MB1536.namprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <177C3BC7DEB81148924CBA2C45063A74@namprd04.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Oct 2017 16:41:34.6333 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0401MB1534 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v92GfjDp031447 On Sat, 2017-09-30 at 11:52 +0530, Alim Akhtar wrote: > Currently UFS HCI uses UFS_BIT() macro to get various bit > position for the hardware registers status bits. Which makes > code longer instead of shorter. This macro does not improve > code readability as well. > Lets re-write these macro definition with the actual bit position. Can the three patches in this series be combined into a single patch? > -#define UFS_BIT(x) (1L << (x)) > [ ... ] > +#define UFS_BIT(x) (1L << (x)) If you want to keep the three patches separate, please make sure that this patch does not modify the UFS_BIT() definition. Please also fix the spelling of the title of this patch (marco -> macro). Thanks, Bart.