From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751888AbdJCK6U (ORCPT ); Tue, 3 Oct 2017 06:58:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44844 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751172AbdJCK6T (ORCPT ); Tue, 3 Oct 2017 06:58:19 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 1C305356EC Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=mguzik@redhat.com From: Mateusz Guzik To: Eric Dumazet , Al Viro Cc: mszeredi@redhat.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 0/2] minor fd cleanup Date: Tue, 3 Oct 2017 12:58:13 +0200 Message-Id: <1507028295-9353-1-git-send-email-mguzik@redhat.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Tue, 03 Oct 2017 10:58:19 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The first patch is a super minor nit and I'm fine with it being ignored. Second patch is imho of actual value. fd_install has an avoidable requirement to be called in a sleepable context. It matters e.g. in rhel7 to where the patch was recently backported and the new requirement could not be enforced. I don't see any benefits from sleeping over locking and not sleeping makes the function slightly nicer. Mateusz Guzik (2): vfs: stop clearing close on exec when closing a fd vfs: grab the lock instead of blocking in __fd_install during resizing Documentation/filesystems/porting | 4 ---- fs/file.c | 12 +++++++----- 2 files changed, 7 insertions(+), 9 deletions(-) -- 1.8.3.1