From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751983AbdJDLOd (ORCPT ); Wed, 4 Oct 2017 07:14:33 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:36853 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751486AbdJDLOb (ORCPT ); Wed, 4 Oct 2017 07:14:31 -0400 X-ME-Sender: X-Sasl-enc: mVZb8KhJcZP9KqNz4DEqXyq10YHU/DlSifTouMeV3cj+ 1507115669 Message-ID: <1507115658.5452.32.camel@aj.id.au> Subject: Re: [PATCH 1/2] ARM: dts: aspeed: Remove undocumented wdt properties From: Andrew Jeffery To: Joel Stanley , Rob Herring , Mark Rutland Cc: Russell King , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, =?ISO-8859-1?Q?C=E9dric?= Le Goater , linux-aspeed@lists.ozlabs.org Date: Wed, 04 Oct 2017 21:44:18 +1030 In-Reply-To: <20171004091635.12499-2-joel@jms.id.au> References: <20171004091635.12499-1-joel@jms.id.au> <20171004091635.12499-2-joel@jms.id.au> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-324F2hv2QDRLq7TZc0Z+" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-324F2hv2QDRLq7TZc0Z+ Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2017-10-04 at 19:46 +1030, Joel Stanley wrote: > The watchdog bindings do not describe an interrupt property nor clock > phandle, and the upstream driver never had code to use them. Drop them > from the device tree. >=C2=A0 > Also rename the node from wdt the more commonly used watchdog. >=C2=A0 > Signed-off-by: Joel Stanley Reviewed-by: Andrew Jeffery > --- > =C2=A0arch/arm/boot/dts/aspeed-g4.dtsi | 7 ++----- > =C2=A0arch/arm/boot/dts/aspeed-g5.dtsi | 8 +++----- > =C2=A02 files changed, 5 insertions(+), 10 deletions(-) >=C2=A0 > diff --git a/arch/arm/boot/dts/aspeed-g4.dtsi b/arch/arm/boot/dts/aspeed-= g4.dtsi > index e455bd236798..5be2e6a39917 100644 > --- a/arch/arm/boot/dts/aspeed-g4.dtsi > +++ b/arch/arm/boot/dts/aspeed-g4.dtsi > @@ -204,17 +204,14 @@ > =C2=A0 status =3D "disabled"; > =C2=A0 }; > =C2=A0 > - wdt1: wdt@1e785000 { > + wdt1: watchdog@1e785000 { > =C2=A0 compatible =3D "aspeed,ast2400-wdt"; > =C2=A0 reg =3D <0x1e785000 0x1c>; > - interrupts =3D <27>; > =C2=A0 }; > =C2=A0 > - wdt2: wdt@1e785020 { > + wdt2: watchdog@1e785020 { > =C2=A0 compatible =3D "aspeed,ast2400-wdt"; > =C2=A0 reg =3D <0x1e785020 0x1c>; > - interrupts =3D <27>; > - clocks =3D <&clk_apb>; > =C2=A0 status =3D "disabled"; > =C2=A0 }; > =C2=A0 > diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-= g5.dtsi > index 77dded187d5a..71e1264b81aa 100644 > --- a/arch/arm/boot/dts/aspeed-g5.dtsi > +++ b/arch/arm/boot/dts/aspeed-g5.dtsi > @@ -248,20 +248,18 @@ > =C2=A0 status =3D "disabled"; > =C2=A0 }; > =C2=A0 > - wdt1: wdt@1e785000 { > + wdt1: watchdog@1e785000 { > =C2=A0 compatible =3D "aspeed,ast2500-wdt"; > =C2=A0 reg =3D <0x1e785000 0x20>; > - interrupts =3D <27>; > =C2=A0 }; > =C2=A0 > - wdt2: wdt@1e785020 { > + wdt2: watchdog@1e785020 { > =C2=A0 compatible =3D "aspeed,ast2500-wdt"; > =C2=A0 reg =3D <0x1e785020 0x20>; > - interrupts =3D <27>; > =C2=A0 status =3D "disabled"; > =C2=A0 }; > =C2=A0 > - wdt3: wdt@1e785040 { > + wdt3: watchdog@1e785040 { > =C2=A0 compatible =3D "aspeed,ast2500-wdt"; > =C2=A0 reg =3D <0x1e785040 0x20>; > =C2=A0 status =3D "disabled"; --=-324F2hv2QDRLq7TZc0Z+ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQIcBAABCgAGBQJZ1MKKAAoJEJ0dnzgO5LT56mUP/Ahy6kILllEcrlf7aQ4yS5Ii y3NaCa7dvOuL7TlZwWJWrUqt2sTW/AFIIeqjpaWZDZ0mLlere+9h3fMxkvHoQWg7 d6hTBEFX5xTE42AEL4WBITL7q7mF+hQxaKgyScKSW8ejJNI2vdRtYEYanOfMrHw/ ERsq5tY83WXqVbdNoy8+jwpxvx5AK1khrrQblf/wvo42Yyv0UKU4DgkHqzIw6a+1 zsAlp40iQLJSL5K4b1dZsvDXgd1HntFFFHNVhz9hlnopwMZX/dmNwU3s/hLxAFrj 85QpxAwaFxwFCW9gFfk3Y2xB9ybaGHd4HD+HASZlNkFdxI9DoBqFt9xDp5MGeZxf zEpOAcj2d6FPdgElFCnK2fK/jxpAPWTK9NHk/9RYftpvTlrpAcz0QwkejC4P8DnD JmjwluYbEDHXhGfPCC31K0gI6cZrafPEfWxmu5G6t1QOn8b8lQHXFBa1I/OvW2NY LPEyye/oDRzGhlXaXHL89VfnytCyQCgvsmMHN1xhRp26yK/wgw2smGVo9SbFqOmX 8DwMPMHcykWLTGClomUOXzyLdBDx148eGWbUgr5vMf70oLSiGO7mGiLqty6RYooy lPBJE/ifzBv6BfPoyC0oUpaIC3qcSYuJ3tIvxlwewZXbkMLgALGmkUckrMZmZ5WB jUk83aQCqkAVDU/WDtat =8NGx -----END PGP SIGNATURE----- --=-324F2hv2QDRLq7TZc0Z+--