From: Alexander Kochetkov <al.kochet@gmail.com>
To: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Dan Williams <dan.j.williams@intel.com>,
Vinod Koul <vinod.koul@intel.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Alexander Kochetkov <al.kochet@gmail.com>
Subject: [PATCH v2 2/2] !!! FOR TESTING ONLY !!! dmaengine: pl330: add verbose message and set NR_DEFAULT_DESC to 1
Date: Wed, 4 Oct 2017 14:37:24 +0300 [thread overview]
Message-ID: <1507117044-3456-3-git-send-email-al.kochet@gmail.com> (raw)
In-Reply-To: <1507117044-3456-1-git-send-email-al.kochet@gmail.com>
Commit add verbose output to pl330 showing what changes introduced by
commit 1/2 from series work as expected. You should see similar output
running modified kernel:
The patch tested on rk3188 radxdarock. Could someone else test it on
other hardware with pl330 DMA?
root@host:~# dmesg | grep pl330
[ 0.277520] dma-pl330 20018000.dma-controller: Loaded driver for PL330 DMAC-241330
[ 0.277538] dma-pl330 20018000.dma-controller: DBUFF-32x8bytes Num_Chans-6 Num_Peri-12 Num_Events-12
[ 0.279894] dma-pl330 20078000.dma-controller: Loaded driver for PL330 DMAC-241330
[ 0.279910] dma-pl330 20078000.dma-controller: DBUFF-64x8bytes Num_Chans-7 Num_Peri-20 Num_Events-14
[ 1.344804] dma-pl330 20078000.dma-controller: pl330_get_desc:2458 Allocated one more descriptor
[ 1.344832] dma-pl330 20078000.dma-controller: pl330_get_desc:2458 Allocated one more descriptor
[ 1.344853] dma-pl330 20078000.dma-controller: pl330_get_desc:2458 Allocated one more descriptor
[ 1.344873] dma-pl330 20078000.dma-controller: pl330_get_desc:2458 Allocated one more descriptor
[ 1.344893] dma-pl330 20078000.dma-controller: pl330_get_desc:2458 Allocated one more descriptor
[ 1.344912] dma-pl330 20078000.dma-controller: pl330_get_desc:2458 Allocated one more descriptor
--- rest of similar lines omitted ---
Signed-off-by: Alexander Kochetkov <al.kochet@gmail.com>
---
drivers/dma/pl330.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
index deec4a4..3441c16 100644
--- a/drivers/dma/pl330.c
+++ b/drivers/dma/pl330.c
@@ -266,7 +266,7 @@ enum pl330_byteswap {
/* The number of default descriptors */
-#define NR_DEFAULT_DESC 16
+#define NR_DEFAULT_DESC 1
/* Delay for runtime PM autosuspend, ms */
#define PL330_AUTOSUSPEND_DELAY 20
@@ -2455,6 +2455,9 @@ static struct dma_pl330_desc *pl330_get_desc(struct dma_pl330_chan *pch)
desc = pluck_desc(&pool, &lock);
WARN_ON(!desc || !list_empty(&pool));
+
+ dev_err(pch->dmac->ddma.dev, "%s:%d Allocated one more descriptor\n",
+ __func__, __LINE__);
}
/* Initialize the descriptor */
--
1.7.9.5
next prev parent reply other threads:[~2017-10-04 11:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-04 11:37 [PATCH v2 0/2] dmaengine: pl330: fix descriptor allocation fail Alexander Kochetkov
2017-10-04 11:37 ` [PATCH v2 1/2] " Alexander Kochetkov
2017-10-16 7:54 ` Alexander Kochetkov
2017-10-17 11:26 ` Marek Szyprowski
2017-10-20 6:17 ` Vinod Koul
2017-10-04 11:37 ` Alexander Kochetkov [this message]
2017-10-17 11:27 ` [PATCH v2 2/2] !!! FOR TESTING ONLY !!! dmaengine: pl330: add verbose message and set NR_DEFAULT_DESC to 1 Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1507117044-3456-3-git-send-email-al.kochet@gmail.com \
--to=al.kochet@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®