From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751291AbdJDQMp (ORCPT ); Wed, 4 Oct 2017 12:12:45 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:55790 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751135AbdJDQMn (ORCPT ); Wed, 4 Oct 2017 12:12:43 -0400 Message-ID: <1507133559.26507.16.camel@collabora.co.uk> Subject: Re: [PATCH] serial: imx: Correct comment imx_flush_buffer() From: Martyn Welch To: Greg Kroah-Hartman Cc: Jiri Slaby , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 04 Oct 2017 17:12:39 +0100 In-Reply-To: <20171003182755.GA32455@kroah.com> References: <1506676939-20940-1-git-send-email-martyn.welch@collabora.co.uk> <20171003182755.GA32455@kroah.com> Organization: Collabora Ltd Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2017-10-03 at 20:27 +0200, Greg Kroah-Hartman wrote: > On Fri, Sep 29, 2017 at 10:22:19AM +0100, Martyn Welch wrote: > > The comment in imx_flush_buffer() states that the state of 4 registers > > are to be saved/restored, then only saves and restores 3 registers. The > > missing register (UBRC) is read only and thus can't be restored. > > > > Update the comment to reflect reality. > > Always run checkpatch.pl so you don't get grumpy maintainers telling you > to run checkpatch.pl :( Sorry Greg, must have got out of sync on that one :-( Martyn