From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751432AbdJDQOa (ORCPT ); Wed, 4 Oct 2017 12:14:30 -0400 Received: from smtprelay0031.hostedemail.com ([216.40.44.31]:60487 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751135AbdJDQO2 (ORCPT ); Wed, 4 Oct 2017 12:14:28 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:967:973:988:989:1260:1263:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2525:2553:2560:2563:2682:2685:2828:2859:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3352:3622:3870:3876:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4321:5007:6117:9025:9388:10004:10049:10400:10848:11026:11232:11473:11657:11658:11914:12043:12048:12292:12555:12682:12740:12776:12895:13069:13311:13357:13439:13845:13894:14096:14097:14107:14181:14659:14721:14849:21080:21451:21627:30054:30055:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: wrist12_60ddf59ffdc48 X-Filterd-Recvd-Size: 1974 Message-ID: <1507133664.4434.7.camel@perches.com> Subject: Re: [PATCH 3/3] wireless: iwlwifi: wrap macro into braces From: Joe Perches To: Christoph =?ISO-8859-1?Q?B=F6hmwalder?= , johannes.berg@intel.com, emmanuel.grumbach@intel.com, luciano.coelho@intel.com, kvalo@codeaurora.org Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 04 Oct 2017 09:14:24 -0700 In-Reply-To: <20171004155700.18048-4-christoph@boehmwalder.at> References: <20171004155700.18048-1-christoph@boehmwalder.at> <20171004155700.18048-4-christoph@boehmwalder.at> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2017-10-04 at 17:57 +0200, Christoph Böhmwalder wrote: > Macros should always be wrapped in braces, so fix this instance. > > Signed-off-by: Christoph Böhmwalder > --- > drivers/net/wireless/intel/iwlwifi/iwl-io.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-io.c b/drivers/net/wireless/intel/iwlwifi/iwl-io.c > index efb1998dcabd..0211963b3e71 100644 > --- a/drivers/net/wireless/intel/iwlwifi/iwl-io.c > +++ b/drivers/net/wireless/intel/iwlwifi/iwl-io.c > @@ -252,7 +252,7 @@ IWL_EXPORT_SYMBOL(iwl_force_nmi); > > static const char *get_rfh_string(int cmd) > { > -#define IWL_CMD(x) case x: return #x > +#define IWL_CMD(x) { case x: return #x; } I think this unnecessary. Maybe: http://lists.infradead.org/pipermail/ath10k/2017-February/009335.html > #define IWL_CMD_MQ(arg, reg, q) { if (arg == reg(q)) return #reg; } But this should use do { ... } while (0)